zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Escape colon at mplayer -ss option
Date: Tue, 30 Aug 2011 17:23:21 +0200	[thread overview]
Message-ID: <CAHYJk3Q=7R_1kCDOcSresejgLga3YBTyduZSJAA2=6v=-dEo1w@mail.gmail.com> (raw)
In-Reply-To: <20110825045107.3CC5540CE6@reinforce.localdomain>

On 25 August 2011 06:42, eagletmt <eagletmt@gmail.com> wrote:
> ---
>  Completion/X/Command/_mplayer |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Completion/X/Command/_mplayer b/Completion/X/Command/_mplayer
> index 665f44e..3cb10d0 100644
> --- a/Completion/X/Command/_mplayer
> +++ b/Completion/X/Command/_mplayer
> @@ -77,7 +77,7 @@ _x_arguments -C -s \
>   '-sid[turn on DVD subtitles]:language id' \
>   '-speed[set playback speed rate]:playback speed rate' \
>   '-srate[specify frequency of audio playback]:frequency (Hz)' \
> -  '-ss[seek to given time position]:position (hh:mm\[\:ss\])' \
> +  '-ss[seek to given time position]:position (hh\:mm\[\:ss\])' \
>   '-sstep[specify time between displayed frames]:time (seconds)' \
>   -ssf:mode -stop_xscreensaver \
>   '-stereo:mode:((0\:stereo 1\:left\ channel 2\:right\ channel))' \

rudi_s mentioned on irc that the [] shouldn't be escaped, then I
noticed they're in the wrong place too, so I'll commit this too,

-  '-ss[seek to given time position]:position (hh\:mm\[\:ss\])' \
+  '-ss[seek to given time position]:position ([[hh\:]mm\:]ss[.sss])' \

-- 
Mikael Magnusson


  reply	other threads:[~2011-08-30 15:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-25  4:42 eagletmt
2011-08-30 15:23 ` Mikael Magnusson [this message]
2011-08-30 16:18   ` Simon Ruderich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3Q=7R_1kCDOcSresejgLga3YBTyduZSJAA2=6v=-dEo1w@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).