From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36238-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 24216 invoked by alias); 19 Aug 2015 02:10:45 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36238
Received: (qmail 28773 invoked from network); 19 Aug 2015 02:10:45 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no
	version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        bh=Q8cjL06DLjvz53dUx9I4YJUdMoT+7n2A74oLMUGMh7g=;
        b=PvrjDalQL7WuPdCLdD0Yrq1ciXTbmgFg8MuctAJ7UGNsXHTL5HOuMof8TkGTi2AowQ
         o3h0cEANovkd1K3pHVIf76XRJUMwp7+SAyStShig27Y+5RAu+n1OMCvHFhrva5aRItKe
         3+p31biFEZjII4/1/rjmqzcjSy0OvlIi7Dtcv9xMd9ZYpppUWtSuCOg44Z03ra/isbD0
         6/0GxWQqVoAimtEScT3q2yEDBEEf3I65T6jhDOrLx47oDFyO01gGe8hRTcCfsMPcDXyl
         sSMXumM5ucImHhWaXZTu4MWk+ol7xeU30Am/4UX4jZnT52MrMuf6HSuYozk0WalhOr7I
         NtsA==
MIME-Version: 1.0
X-Received: by 10.107.3.149 with SMTP id e21mr9329630ioi.19.1439950242761;
 Tue, 18 Aug 2015 19:10:42 -0700 (PDT)
In-Reply-To: <20150819020536.GE2005@tarsus.local2>
References: <20150819020536.GE2005@tarsus.local2>
Date: Wed, 19 Aug 2015 04:10:42 +0200
Message-ID: <CAHYJk3QDaBiMxLeG=+dUwt1=Pu7wzKi1Qtbeovok7nFq8vvdMA@mail.gmail.com>
Subject: Re: [PATCH] _git-cat-file blob completion fix
From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 19, 2015 at 4:05 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wro=
te:
> 'git cat-file HEAD:<TAB>', when cwd is a subdirectory of a repository,
> completes files within that subdirectory, but should complete files
> relative to the repository root.  The attach patch implements that.
>
> Review would be appreciated =E2=80=94 I might have missed something while
> reverse-engineering the semantics of everything.  (I already checked
> gitrevisions(7) and tested 'git rev-parse HEAD:<TAB>'.)
>
> I didn't make --root-relative a zparseopts option because I didn't want
> to have to name the same as git option it maps to.

You can say HEAD:./foo to specify foo relative to the current
directory. However, this doesn't work in the current completer either
afaict, so it's not a regression to apply this patch :).

--=20
Mikael Magnusson