From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19787 invoked by alias); 29 May 2017 13:21:25 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41178 Received: (qmail 10607 invoked from network); 29 May 2017 13:21:25 -0000 X-Qmail-Scanner-Diagnostics: from mail-qt0-f182.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.216.182):SA:0(-0.2/5.0):. Processed in 2.236337 secs); 29 May 2017 13:21:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM, SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.216.182 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AE5l8akeMk35OnSIx+cAHU49j3rmr75em+bT+xtwLUA=; b=TBiykf7UZZYGxIVr1RdVqKjhoP1hQt9BMjqjVN/Kt6FEvGpz/Lh1lrRM2lS2X9nvwn C3lDz3u+5R9jid5qkWz+gwzIjEIdGEvt7nHGEDJJNzK9KZycke7B1a3eEKXe7Rbb8M0s XMZrXZDoRiMswOdhe+lEgnZh0RfEqP15/swDzom+B2FQ/PDDIcSWVINBSko2i6b9NOZW 51S8fEcXl0QNSW8TyyxGdA3LIOj2emUabnBhDZQpCmss5Ge707ssoy3FDcIbhWRCZvOu NhcwPe8Cqt6A3kHYmJLUpkRXTn+i4h7UgXCXolsZqHzG1ARf7dqSAHQl+m0gxJmn6tGv kUEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AE5l8akeMk35OnSIx+cAHU49j3rmr75em+bT+xtwLUA=; b=D4mysdjCHLvYDxLNCf6Ho2DVqMftqWDS5JKt8mRdAkqzo8dhFLaMniPOImvWynZJsr YL6XUXpFUsSynuxdYK2j+sC99kv/EDAYF+76Qlgv6OQ8ULz/L9m9AwhJfAIde/KabHVi q/KwVpwqzAkhF23dpve3ucXqdxkdoscOJwuuODj+1WBi5rdVuWX5VmbjiGHyKz1bNohG V9V6HXcJVU2jD+iC2Z+fUMv/bh0U0I4c8wqaL83smkRi6C7XNy+FpKexQjUhjv1Pu5hQ C8AkuVy58Ic4zkd/rKS5Fyi5+aVVEBHKHZj3xjbfbjG6ExZcvJhgWrb73JGtX2LeDz65 nALw== X-Gm-Message-State: AODbwcCaYJKkz/1PkZbd9+CTnpSQDfqBDNP+DRST5hrzCYZX9iZZ8Ezr JO9/znUpwfEbzTL1KAvBbV2X13w/lA== X-Received: by 10.200.46.70 with SMTP id s6mr19089841qta.48.1496064075900; Mon, 29 May 2017 06:21:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <170528124337.ZM9444@torch.brasslantern.com> References: <170528124337.ZM9444@torch.brasslantern.com> From: Mikael Magnusson Date: Mon, 29 May 2017 15:21:15 +0200 Message-ID: Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas) To: Bart Schaefer Cc: zsh workers Content-Type: text/plain; charset="UTF-8" On Sun, May 28, 2017 at 9:43 PM, Bart Schaefer wrote: > On May 26, 7:04am, Sebastian Gniazdowski wrote: > } > } The arrlen branch seems to faint. I had this idea of employing > } valgrind, to get certain about code in the branch. > } > } Found 4 errors, instantly. > > I took a stab at merging mikachu/badarrays into the current master, > and for the most part it was straightforward, but there are too many > conflicting changes to Src/params.c (different numbers of values in > the replacements for the whole suite of IPDEF macros, of which more > have been added in the meantime; bug fixes in getarrvalue() that > overlap the PM_CACHLEN changes). I gave up on attempting to follow > what would need to be be edited to bring the latest code up to date. > > I could push the current broken (won't compile) state up to the origin > (I branched my merge as schaefer/badarrays) if Mikachu is interested in > cleaning up params.c. In the meantime it's probably not worthwhile to > attempt memory checking on mikchu/badarrays. Well, it never worked in the first place, that's why i put "bad" in the name. It's basically just a documentation of the places I found that would need to be updated to use a cached length value, but since it doesn't work I guess I didn't find all of them, or I misunderstood some parts of the code that I changed... -- Mikael Magnusson