From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-37644-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 962 invoked by alias); 15 Jan 2016 14:46:14 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 37644
Received: (qmail 23942 invoked from network); 15 Jan 2016 14:46:13 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=VJZuxmqschDgyzMY+9+qdsm7cztz9KprFRKsq65RLRU=;
        b=lYJrFn8pZgpysVQS/qjvaMKyqUwY4SWjfPF0Z8Es5ojh6eyIQf//6X0M7VFdS1itZn
         nLlk5k3SEY8SH5vaWA/C60GtE15gYi55qetnoCHQcRAPNU9g+3dfwOOR01AQtbqp3u9p
         7yHF9xfDqwdgsdet8tGiXEFxBfDF43uQHkP7yY2mrq0R8wikin1KJQGO93ZtVbhSgqf2
         7MUBIKsa4l/Nc4GvRwX3n3WkKHGBia+1ChpxwygxlyAeB4wfIyo1nJLg7QuTmKTClvY/
         JBi9GbT13T0QtPwlCV37oK+RumaeGdjeRI9es66UMk219jCEoPdh0utXHSD1x7Ut10gV
         /m1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:cc:content-type;
        bh=VJZuxmqschDgyzMY+9+qdsm7cztz9KprFRKsq65RLRU=;
        b=YeWVop6sIBN6DXpjKthGh53goTYcz0WbjzAS7aiTG0hkU0uq/C7POF3cLnL+oeMX9a
         tsCVnXIE6b2DA3H4XFQzhw1DgZ+mT+Ev2s5wx4zHIRawgnIT9YO3BvDaDwAb6zPCIVLY
         0tbFvejXJN9sMeaLB73bMet22MP80eAHsmEEESF8p3PnMat9fbU9VSTBsGwP2I65i8IJ
         +B0GvFHWRoZ25xC/GLJ3qOChwa6qA0ZLsx1bpG5L6Gk/75rSEnpaUrOUSnxpRxMcJ5Kn
         UjSzAhe5cKTJdTL2WSFcPa6wJe23fsXb+cAnd3mENOfmW8UYIgTFdxKsfojt/IyhmuvO
         C/dQ==
X-Gm-Message-State: ALoCoQkusxQynhGeUI2Lb20LPQ6BmZeh9/LB6ELJOy4czCSBEdnmNl+7h9g+ngEgLtvIu64TaxPsA0hRVLxgdSGuTU6Ho0coTQ==
MIME-Version: 1.0
X-Received: by 10.140.100.141 with SMTP id s13mr13132495qge.25.1452869169552;
 Fri, 15 Jan 2016 06:46:09 -0800 (PST)
In-Reply-To: <20160115062645.GB12223@tarsus.local2>
References: <20160114001336.GA11173@tarsus.local2>
	<56973114.90807@gmx.com>
	<20160115062645.GB12223@tarsus.local2>
Date: Fri, 15 Jan 2016 15:46:09 +0100
Message-ID: <CAHYJk3QLCCVmZf4efzQgxs3haKv2mssQk3cGQXd5fm7DK7dgGg@mail.gmail.com>
Subject: Re: [PATCH] typeset: set $? on incidental error
From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Eric Cook <llua@gmx.com>, zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Fri, Jan 15, 2016 at 7:26 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Eric Cook wrote on Thu, Jan 14, 2016 at 00:24:36 -0500:
>> On 01/13/2016 07:13 PM, Daniel Shahaf wrote:
>> > The 'typeset' family of builtins doesn't set $? when one would expect it
>> > to do so:
>> >
>> >     % x=$(true) y=$(exit 42); echo $?
>> >     42
>> >     % local x=$(true) y=$(exit 42); echo $?
>> >     0
>> >
>> > This patch makes 'typeset' behave as ordiary assignment does.
>>
>>
>> But who expects that?
>
> I did.

local/typeset is a command, and it was successful, so I don't see why
$? should be set to anything else than 0.
% true x=$(false); echo $?
0
is technically exactly the same situation as your above second command.

-- 
Mikael Magnusson