From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28168 invoked by alias); 6 Jan 2015 00:55:31 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34102 Received: (qmail 28214 invoked from network); 6 Jan 2015 00:55:29 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=kly+0ovmJ8YGk6RCTjxAuQJwarZ7gbxQmEWGY8Kj7lc=; b=A3mzg1RS6wh2MU/5PpUGXrNizmRN7KEMzYs4jDO6FdZZW/u2rL1TmBgd23ml9hDy4x Y3pvFUhqVlaO3KdNfgcojJcZoWF2D1jA4lsNZHbPNTGnRTTOeZZ/hhGTv+V6hkeo4Str jvVJPUI9oen1EMcsD9dretaLU4cwXxgcDEcEop8M3ImqSPB9MNYELsBjNAeSNGAsVSVK MT7hbiytkOv3TXSL+sRhSNUiYlRScK9wiUJXpiOgp8tgRbMs5r/KuWPgjWr7jIG9nvzm gVu2FOYKhAiDfmCudItexAp9IU6WyoALid67TDxZ7Jxqo0lqDZemZvbm3TKWn2tH7MOQ vVQw== MIME-Version: 1.0 X-Received: by 10.50.117.41 with SMTP id kb9mr13574936igb.37.1420505727472; Mon, 05 Jan 2015 16:55:27 -0800 (PST) Date: Tue, 6 Jan 2015 01:55:27 +0100 Message-ID: Subject: dead code in subst_parse_str From: Mikael Magnusson To: zsh workers Content-Type: text/plain; charset=UTF-8 A while ago, this was committed, https://sourceforge.net/p/zsh/code/ci/5fdcd3a2b468 If you look carefully (or at coverity), you'll notice that qt is set to 0 initially, and then only toggled to 1 if it is already 1, ie never. This is again a case of I have no idea what's happening here, so I'll let you guys look at it. -- Mikael Magnusson