From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2001 invoked from network); 12 Mar 2021 20:53:43 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 12 Mar 2021 20:53:43 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1615582423; b=Jdt2QREnXDLk0M7zbLDfP4E30NGG9s/OtA5raeXLMZ4qqLpt8GpMBPAJxogbMWEMdGmrTa1UAE 5m4zq9PftOZRSNiBYAxjrH7eBnLuQxmb3PksBqea7PVnWFW4tVsofk7zmKjfNG9FnNuPNZtULb Oxi6435iL21JqrFuAbIPcXPjnMwn3D/KpiokYPRHTV4p4RB9YQI+sBspWVT9pj9MUflbyZPzoD W+E13ayEf7VbQnZAfSd0KUvJRzjsL6UVnwaBx6Y7jIlVXSQFJ7Qx0T3cLyumrCpks1aNKDGH3T IczqATB4v2k8hxnWLR2FYDm65lqLWyBUaguG+VOTplQkog==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-io1-f53.google.com) smtp.remote-ip=209.85.166.53; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1615582423; bh=C+J2ghK7M+tzMihyfFa2wRCWtn4N2UjolIrvyHBZl9Y=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:References: In-Reply-To:MIME-Version:DKIM-Signature:DKIM-Signature; b=HO5+Fsm6PDNJMEt0Gh2YLav1mAhy9fIEwZ3JGhgT3iQheSXqyf2aMCtk2zph4feNvxYqcThbf8 v843TS3txwvAxTxvASkVa9h4pTXBprWRQhm25j++qQOpDvK0PkuK1Wzi2h4nTrQnHFi19FphpU hcYF7KA6U7ro1NqyIpj8KtS1XuTTUZs0AjwL4jJIB7TcbWwB5WAC3np9QE7DuXrkhpVxqGpRwg dgzRMuxhRQoObaKtyZUML0kA39VLKAzKMei2KL5uSSw84I/ACHHZ2EaFmzp4TSldh9o3gPeWuN xoBVf4ERoS3/X8d2Yv1oauujT+Z/LcoBawJ/sw4BjmFC1w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:References:In-Reply-To:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=3p0GOfYnnYlwgMVzdFPLE0YTcGhEBQzGQMzw78FY94s=; b=bGH4gsWpvj1IgS0QGwN9W3RBur 9sQlxPyftJaRd9aV74zdDTEPwtbb0cX6kFDSIbluQc3imyzpGBPBTQG/h/NedUpfZW0dHTRbYMSGH 5CtW0glAw9efP1cnooIkmnb77XcmK5CvTMGo+yhde3tG0qWNG6L7HMrU3iRaNq4eltdjB0jLZQHi2 YflMH8Ko9imjDPybuxT2ioDUrd5se6KSLWtgk4O9tuE+XLFfdsdCIf9k2qYDMP/5dKN9k3le2IZOM hWo3EdyWjuMcmEz6BIrxTUwcn9VJxwJ9XubpYDfj8okkpwb93cfPWDl4OGcgSUcpZlYPFe0co4ux1 9h360fDg==; Received: from authenticated user by zero.zsh.org with local id 1lKomu-000Bkd-GD; Fri, 12 Mar 2021 20:53:36 +0000 Authentication-Results: zsh.org; iprev=pass (mail-io1-f53.google.com) smtp.remote-ip=209.85.166.53; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-io1-f53.google.com ([209.85.166.53]:39592) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lKomd-000BbH-9I; Fri, 12 Mar 2021 20:53:20 +0000 Received: by mail-io1-f53.google.com with SMTP id o9so27184710iow.6 for ; Fri, 12 Mar 2021 12:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3p0GOfYnnYlwgMVzdFPLE0YTcGhEBQzGQMzw78FY94s=; b=AQBz0couYKFG5G25wgsxnWUxEBlicwqEEmRbUYZz2hED+ZH7v0Xz6xiqGF58lq7ClH As/YJY8PSbxFtyI3V1JeRGs/cyA7JRTtA8jEgaQ0AvzqnYEO3da/Pj+9ITlyTsShjNxI 6NDHdXenw6nZ8HOKS2trKBI2IuAJ2Y/W9rIYE+6aDWMs/SRjai7+zEjoh8VLoLzJp10C V9Qv7LsJv0ZXNfc4dWR1ctRLcN+bJvOWpUAke/0jHfiMNOcA5RdcHWhJE0InkTa58o4W RlkkzCwdcm3AJhnqMszUUi1G4yN0cCf+uEWc4s6KeHv8zmLZmnSp0kwa/0npU4Qt8lQq btaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3p0GOfYnnYlwgMVzdFPLE0YTcGhEBQzGQMzw78FY94s=; b=JyaLeI3wBlVCWw6kP2LQNP1oH0lXI0Zw3UFICpAKFCaFQcCj+XWQz2MjsJOWr/QeuC yGxJWhRiiP/V3iCH8Q3VeIF9qRJV2+cxXOed9rBX8zsUc4iFYikl5SxLNRMCozfMN5FF tm20EOWXAzEAqe/COj2PNvLnKmUZHtVjlhq4qiJrlogla1bjBtS5LZfU4tJGQ4XNewgT NtHQATu2T0F2HtXte+Ydg50jB9Q+0naWffoRGsuYt8uWKasaL2vfTilMcr4gOtv2rElY iJqIF3CTvWy2sheuxaPf+08WoQKS52o+L5Syz0fEEt64na3B8surBYd2IC7gBxI+m7Z2 y/zQ== X-Gm-Message-State: AOAM532eee2UnDigiTjVlcGVJ/Bf1T7knJ6gGO5Sn0nWNOJnnWRF4c35 NTtF3c91WdHCnyNEKB4LzsvVM9PAP0/yj4VHgscKCg7R X-Google-Smtp-Source: ABdhPJxPy7qbHgrUwqaLI2sgzkXB8ZQWfuP3GowyVuw2fqOYD1goPo+VUc8v4q2FbfL62G33Xs7rmMtIp6UVceRCAV4= X-Received: by 2002:a02:970e:: with SMTP id x14mr1028396jai.127.1615582392973; Fri, 12 Mar 2021 12:53:12 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a4f:c801:0:0:0:0:0 with HTTP; Fri, 12 Mar 2021 12:53:12 -0800 (PST) In-Reply-To: References: <20210304201721.GA16874@tarpaulin.shahaf.local2> <20210307172246.GB9936@tarpaulin.shahaf.local2> <1084110603.423549.1615556176994@mail2.virginmedia.com> From: Mikael Magnusson Date: Fri, 12 Mar 2021 21:53:12 +0100 Message-ID: Subject: Re: Bug + patch: `zstyle ':completion:*' menu select=long-list` fails to start menu selection To: Daniel Shahaf Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 48175 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On 3/12/21, Daniel Shahaf wrote: > Peter Stephenson wrote on Fri, 12 Mar 2021 13:36 +00:00: >> >> > On 12 March 2021 at 13:11 Marlon Richert >> > wrote: >> > >> > >> > I found the culprit: I had >> > >> > export GREP_OPTIONS='--color=always' >> > >> > in my `.zshrc` file and that mangled the .mdd file names. >> >> It's probably worth having the following. It doesn't cover all the >> possible cases where you can get into trouble, but it's a useful >> blanket for the standard case where everything is done immediately >> from configure. >> > > I'm not sure I agree. > > - This seems to be a cases of "hard cases make bad law". Setting > --color=always in the environment will break any script that expects > grep(1)'s standard semantics, not just configure. The patch just > papers over the problem. > > - We shouldn't second-guess the user. If the user has GREP_OPTIONS set > in the environment, that might actually be needed in order to have > grep(1) behave correctly. What if some system uses GREP_OPTIONS to > make its grep(1) tool behave POSIX compatibly? > > - If this fix is needed, we should send it to autoconf upstream to be > incorporated into AC_PROG_GREP. > > Instead, I propose: > > - Audit configure.ac and make sure we use $GREP rather than grep. > Perhaps push this into the makefiles and build scripts too. > > - Consider issueing a notice if GREP_OPTIONS is set, or proposing to > upstream to have AC_PROG_GREP do so. > > - Sending a documentation patch to grep(1)'s man page to point out that > using --color=always globally or on the left hand side of a pipe is > inadvisable. For what it's worth, my grep (GNU grep 3.1) says this when I use GREP_OPTIONS: % GREP_OPTIONS=hi grep grep: warning: GREP_OPTIONS is deprecated; please use an alias or script -- Mikael Magnusson