From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34100-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 22237 invoked by alias); 6 Jan 2015 00:32:42 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34100
Received: (qmail 23164 invoked from network); 6 Jan 2015 00:32:41 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=PbqOhYURROlZryD2i+1Aqm/6DVQ5qKBzVHYZd5r46+Q=;
        b=Egno1LGhSXs8hytHtPgl3vkLDmTeyXh9DZbYhF59PB7H7nZNJZRnvDBqXC/VMAtYFT
         oVNdCCFEeK1uwXuNAtaU+fNcvHlox1aOzBNWLGfTp6bPgojNeQU8FKfTSqQMfTXQff1W
         QdoskCs41LnZYRLSX10yOm6Zc7h/hlYwnVay4tWWw8JiTR7GAPBvjxw9CcsCrm69yZP5
         CEeEYnfiZ2g7HPjSfzLeVVZienE+HILskP9djb/Iplmb/KuqP+bV4cYm/SH4iDuWRsZy
         wSWdQt+AFnjgvJE0aI+DyHfVTBYKflOPdFabxQAQcOGqRmK4Va04Ju+lhGUSU9kupkxQ
         IqDQ==
MIME-Version: 1.0
X-Received: by 10.107.130.197 with SMTP id m66mr83335417ioi.10.1420504358639;
 Mon, 05 Jan 2015 16:32:38 -0800 (PST)
In-Reply-To: <1999441420503885@web17g.yandex.ru>
References: <CAHYJk3RZ_1pcJEfJjUqT8P+kxrEOqBudHvdZqWoK6ZsdkP=G4A@mail.gmail.com>
	<1999441420503885@web17g.yandex.ru>
Date: Tue, 6 Jan 2015 01:32:38 +0100
Message-ID: <CAHYJk3QP+mPCGpjia6aB+UxwGa9ePVceK7v4RBu-aMC5epYLRw@mail.gmail.com>
Subject: Re: Fishier code in handlefeatures
From: Mikael Magnusson <mikachu@gmail.com>
To: ZyX <kp-pav@yandex.ru>
Cc: Peter Stephenson <p.stephenson@samsung.com>, zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Tue, Jan 6, 2015 at 1:24 AM, ZyX <kp-pav@yandex.ru> wrote:
> 06.01.2015, 03:21, "Mikael Magnusson" <mikachu@gmail.com>:
>> mod_export int
>> handlefeatures(Module m, Features f, int **enables)
>> {
>>     if (!enables || *enables)
>>       return setfeatureenables(m, f, *enables);
>>     *enables = getfeatureenables(m, f);
>>     return 0;
>> }
>>
>> so if enables is NULL, we immediately do *enables? I'm not sure what's
>> intended here but obviously it somehow works.
>
> NULL is false, so if enables is NULL !enables is true and *enables is not evaluated due to short-circuiting. Nothing wrong here.

Read the next line too.

-- 
Mikael Magnusson