zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: dana <dana@dana.is>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Misaligned cursor when prompt linebroken
Date: Thu, 18 Apr 2019 20:56:29 +0200	[thread overview]
Message-ID: <CAHYJk3QQVQ=tKELeAbnunfyKODKRdGq-HjQpfXvwrDXtAMBgjA@mail.gmail.com> (raw)
In-Reply-To: <CAHYJk3QcuDqA-vePBWeURQ-JJ82C1e-guAdA9ZG78yjO1tyKLQ@mail.gmail.com>

On 4/18/19, Mikael Magnusson <mikachu@gmail.com> wrote:
> On 4/18/19, Mikael Magnusson <mikachu@gmail.com> wrote:
>> On 4/18/19, dana <dana@dana.is> wrote:
>>> On 18 Apr 2019, at 10:39, Mikael Magnusson <mikachu@gmail.com> wrote:
>>>>PS1=${(l:$COLUMNS::a:)}b
>>>>the cursor is placed on top of the "b" for me, both in urxvt and
>>>>xterm. Under zsh -f the initial rendering appears correct, but not
>>>>after I type two characters
>>>
>>> Same for me in Terminal.app. The return of workers/43267 (&al.), i
>>> suppose?
>>
>> Just a small additional note that it doesn't matter that it's only one
>> character extra in my example, the same thing happens if you put
>> bbbbbbbb instead of just b.
>
> I tried reverting that commit (w/42285) and it fixes my problem. I
> also can't reproduce any behavior that erases lines with it reverted.
> Since having the commit breaks all prompts that are longer than one
> line in many(?) terminals, and only fixes the case where it is exactly
> as long as one line in some(?) terminals, I would argue for reverting
> it in git.

Dana pointed me more specifically to w/43288 on IRC which was
reportedly committed a while ago but not actually. I checked that it
fixes my case too and doesn't seem to break w/42285, so I've committed
it (actually).

-- 
Mikael Magnusson

      reply	other threads:[~2019-04-18 18:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 15:39 Mikael Magnusson
2019-04-18 17:56 ` dana
2019-04-18 18:29   ` Mikael Magnusson
2019-04-18 18:40     ` Mikael Magnusson
2019-04-18 18:56       ` Mikael Magnusson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3QQVQ=tKELeAbnunfyKODKRdGq-HjQpfXvwrDXtAMBgjA@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=dana@dana.is \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).