help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Stefan Radziuk <sradziuk@pdtpartners.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Using the history expansion modifier 'a' results in excessive lstat calls
Date: Fri, 20 May 2022 12:34:52 +0200	[thread overview]
Message-ID: <CAHYJk3QTi9f7h92HkAZbOGkQ9nqVNGJFByJrBDN6C-W7+CYm4Q@mail.gmail.com> (raw)
In-Reply-To: <CY5PR20MB4843E231D8BA513A209C6541C1D39@CY5PR20MB4843.namprd20.prod.outlook.com>

On 5/20/22, Stefan Radziuk <sradziuk@pdtpartners.com> wrote:
> zsh uses zgetdir to evaluate ${FOO:a}. When in a directory in a different
> filesystem to its parent,  zgetdir will lstat many entries in the parent.
> This leads to slowness, especially when some of the lstatted entries are on
> remote filesystems.
> This behaviour can be avoided by making zsh use getcwd instead (build zsh
> with USE_GETCWD). Interestingly, getcwd will also be used in the regular zsh
> build if zgetdir fails (see the implementation of zgetcwd).
> I have looked through some threads in the mailing list to find out why
> zgetdir is being used over getcwd in the first place. It seems it was
> implemented this way in the 1990s to work around a bug in some
> implementations of getcwd, which should not be a concern on modern systems.
> I was wondering if zgetdir is still the right way to do this? Are there use
> cases where it is preferred over getcwd? Maybe zgetcwd could simply use
> getcwd primarily (i.e. not as fallback), or perhaps USE_GETCWD could be
> enabled by default (currently it is only enabled on QNX builds).

Do you get the same results with :P ? :a and :A are not guaranteed to
result in a path leading to the same file (eg, symlink/../ will be
simply deleted without following the symlink etc)

Mikael Magnusson

  parent reply	other threads:[~2022-05-20 10:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 10:08 Stefan Radziuk
2022-05-20 10:15 ` Peter Stephenson
2022-05-25  9:53   ` Peter Stephenson
2022-05-25 10:22     ` (EXT) " Stefan Radziuk
2022-05-25 10:33       ` Peter Stephenson
2022-05-26  8:35         ` Peter Stephenson
2022-05-20 10:34 ` Mikael Magnusson [this message]
2022-05-23 11:32   ` Stefan Radziuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHYJk3QTi9f7h92HkAZbOGkQ9nqVNGJFByJrBDN6C-W7+CYm4Q@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=sradziuk@pdtpartners.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).