zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Fix use-after-free for print -zf and print -sf
Date: Tue, 10 Feb 2015 08:16:56 +0100	[thread overview]
Message-ID: <CAHYJk3QWK-z-WA4-8EC_m+PYc8QACt_GPjNqC2FXqRQk4VF-xg@mail.gmail.com> (raw)
In-Reply-To: <1423552346-18827-1-git-send-email-mikachu@gmail.com>

On Tue, Feb 10, 2015 at 8:12 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
>      /* Testing EBADF special-cases >&- redirections */
> -    if ((fout != stdout) ? (fclose(fout) != 0) :
> +    if (fout && (fout != stdout) ? (fclose(fout) != 0) :

Do I need an extra set of parens here? C precedence rules are fun.

-- 
Mikael Magnusson


  reply	other threads:[~2015-02-10  7:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  7:12 Mikael Magnusson
2015-02-10  7:16 ` Mikael Magnusson [this message]
2015-02-10  9:37   ` Peter Stephenson
2015-02-10 11:13     ` Mikael Magnusson
2015-02-10 11:18       ` Peter Stephenson
2015-02-10 11:32         ` Mikael Magnusson
2015-02-10 11:38           ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHYJk3QWK-z-WA4-8EC_m+PYc8QACt_GPjNqC2FXqRQk4VF-xg@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).