From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34489-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 4733 invoked by alias); 10 Feb 2015 07:17:05 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34489
Received: (qmail 24503 invoked from network); 10 Feb 2015 07:17:03 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=PKtHqo+PzW0+6e7qitD0Pv6dK4i27q10e5pD7KkUGr0=;
        b=HWncv0p8Y8kEBMwsegYqBPSJLtKuaxtEG2pqfdHhh4x+LL9KIBo08VxSIm0gNgLnJE
         nV2AD5hYhNYlcZCeQAA7BujU1ZDBc4JP55qYN1/kiCJzDJUY7CdhfwI3/6S0RpHj9Kwg
         pFj54R6Y4K+UEnX796vNFW3QyOAGdOTjHwbudiNmTxPcJfBxgGkeeMhQREs2epBHEHO+
         0eAdP5A7uDx+v8b6s+g0LQ5/XW7WTqCiw70CB+q+WUkaA1VbK7SUw1uiu1XpVp3HwbOW
         X6y000UBRhpKE4RFLga0vITpCi8iL4kxMfYE7vpdfRtADR34k03VGpTSvD/N3s+HdtKZ
         t88A==
MIME-Version: 1.0
X-Received: by 10.50.50.142 with SMTP id c14mr21350307igo.42.1423552616822;
 Mon, 09 Feb 2015 23:16:56 -0800 (PST)
In-Reply-To: <1423552346-18827-1-git-send-email-mikachu@gmail.com>
References: <1423552346-18827-1-git-send-email-mikachu@gmail.com>
Date: Tue, 10 Feb 2015 08:16:56 +0100
Message-ID: <CAHYJk3QWK-z-WA4-8EC_m+PYc8QACt_GPjNqC2FXqRQk4VF-xg@mail.gmail.com>
Subject: Re: PATCH: Fix use-after-free for print -zf and print -sf
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Tue, Feb 10, 2015 at 8:12 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
>      /* Testing EBADF special-cases >&- redirections */
> -    if ((fout != stdout) ? (fclose(fout) != 0) :
> +    if (fout && (fout != stdout) ? (fclose(fout) != 0) :

Do I need an extra set of parens here? C precedence rules are fun.

-- 
Mikael Magnusson