From: Mikael Magnusson <mikachu@gmail.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: zsh (live version): setting globassign crashes completion
Date: Tue, 2 Jun 2015 16:21:25 +0200 [thread overview]
Message-ID: <CAHYJk3Q_oTZcxHktQZE_VC60UEaBSAtfnFT9SschDbu58HgP8w@mail.gmail.com> (raw)
In-Reply-To: <20150602150004.494d2311@pwslap01u.europe.root.pri>
On Tue, Jun 2, 2015 at 4:00 PM, Peter Stephenson
<p.stephenson@samsung.com> wrote:
> On Tue, 2 Jun 2015 15:45:09 +0200
> Mikael Magnusson <mikachu@gmail.com> wrote:
>> My money is on
>> "33816, 33819: GLOB_ASSIGN changes integer and floating type variables
>> to string scalars"
>> I checked that my patch still passes the test added by those patches,
>> and it does.
>
> (Moved to zsh-workers.)
>
> Ick.
>
> We'd better do this, too.
>
> pws
>
> diff --git a/Test/E01options.ztst b/Test/E01options.ztst
> index 5c453c8..195ce56 100644
> --- a/Test/E01options.ztst
> +++ b/Test/E01options.ztst
> @@ -483,6 +483,14 @@
> >tmpcd tmpfile1 tmpfile2
> >tmp*
>
> + (setopt globassign
> + typeset -A foo
> + touch gatest1 gatest2
> + foo=(gatest*)
> + print ${(t)foo})
> +0:GLOB_ASSIGN doesn't monkey with type if not scalar assignment.
> +>association-local
> +
> mkdir onlysomefiles
> touch onlysomefiles/.thisfile onlysomefiles/thatfile
> setopt globdots
Hm, there's one GLOB_ASSIGN test in A06 and one in E01, should we move
them together? Also, my patch had some unrelated gunk in the context,
sorry about that.
--
Mikael Magnusson
next prev parent reply other threads:[~2015-06-02 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <556D9EBE.4050702@gmail.com>
[not found] ` <20150602143606.346a5abc@pwslap01u.europe.root.pri>
[not found] ` <CAHYJk3QDmytycz+A=bP7rKnVsYK_MYcGWg6sjQskhwtPwWggnw@mail.gmail.com>
2015-06-02 14:00 ` Peter Stephenson
2015-06-02 14:21 ` Mikael Magnusson [this message]
2015-06-02 14:25 ` Peter Stephenson
2015-06-02 15:12 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3Q_oTZcxHktQZE_VC60UEaBSAtfnFT9SschDbu58HgP8w@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).