From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35367-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 8630 invoked by alias); 2 Jun 2015 14:21:31 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35367
Received: (qmail 13955 invoked from network); 2 Jun 2015 14:21:28 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=zAajJdEBOLkXxJJrFFla3hSClkIaaSgvkoigmthx1Rk=;
        b=aCcUD+nih/za2waDx29Bw9BXB6cKy2+uwfi1noA2yQM96iDlrTvzwkV/hEwqKrN74p
         lPYhMnl6x0c9izmtWm1PpUkzrRXsTyD6DudprZH2OtSUXWxuzljfZgfiXpdZZBjxEDvh
         xTfUxaYvidQ+xTlwZZH+lpsUcOciaKPWGQxA81pJrgHBbkg5QHfXS4ZX4JTybliI2MPC
         aVCfxF+tCMl7y8sByDqiW6jB8h6S9ZJoBp/KsT7JilgCBai1ooTakx59WBRyTp/ck5GQ
         V0sUVeqVs2jcZH77NxmMYi4BopFZydtFVJ1kuV/j1tnz1wCiL9VEtn2Tp/TUILZXIVjH
         NZUQ==
MIME-Version: 1.0
X-Received: by 10.50.43.196 with SMTP id y4mr20443837igl.14.1433254885353;
 Tue, 02 Jun 2015 07:21:25 -0700 (PDT)
In-Reply-To: <20150602150004.494d2311@pwslap01u.europe.root.pri>
References: <556D9EBE.4050702@gmail.com>
	<20150602143606.346a5abc@pwslap01u.europe.root.pri>
	<CAHYJk3QDmytycz+A=bP7rKnVsYK_MYcGWg6sjQskhwtPwWggnw@mail.gmail.com>
	<20150602150004.494d2311@pwslap01u.europe.root.pri>
Date: Tue, 2 Jun 2015 16:21:25 +0200
Message-ID: <CAHYJk3Q_oTZcxHktQZE_VC60UEaBSAtfnFT9SschDbu58HgP8w@mail.gmail.com>
Subject: Re: zsh (live version): setting globassign crashes completion
From: Mikael Magnusson <mikachu@gmail.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Tue, Jun 2, 2015 at 4:00 PM, Peter Stephenson
<p.stephenson@samsung.com> wrote:
> On Tue, 2 Jun 2015 15:45:09 +0200
> Mikael Magnusson <mikachu@gmail.com> wrote:
>> My money is on
>> "33816, 33819: GLOB_ASSIGN changes integer and floating type variables
>> to string scalars"
>> I checked that my patch still passes the test added by those patches,
>> and it does.
>
> (Moved to zsh-workers.)
>
> Ick.
>
> We'd better do this, too.
>
> pws
>
> diff --git a/Test/E01options.ztst b/Test/E01options.ztst
> index 5c453c8..195ce56 100644
> --- a/Test/E01options.ztst
> +++ b/Test/E01options.ztst
> @@ -483,6 +483,14 @@
>  >tmpcd tmpfile1 tmpfile2
>  >tmp*
>
> +  (setopt globassign
> +  typeset -A foo
> +  touch gatest1 gatest2
> +  foo=(gatest*)
> +  print ${(t)foo})
> +0:GLOB_ASSIGN doesn't monkey with type if not scalar assignment.
> +>association-local
> +
>    mkdir onlysomefiles
>    touch onlysomefiles/.thisfile onlysomefiles/thatfile
>    setopt globdots

Hm, there's one GLOB_ASSIGN test in A06 and one in E01, should we move
them together? Also, my patch had some unrelated gunk in the context,
sorry about that.

-- 
Mikael Magnusson