From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Don't store ZLE_LINE_ABORTED in vared context
Date: Thu, 5 Mar 2015 03:41:28 +0100 [thread overview]
Message-ID: <CAHYJk3QbXZQqPJpd0Wxvx6pVjmCmiB=yQN5RmRfKXdbhUtCqnw@mail.gmail.com> (raw)
In-Reply-To: <150304175726.ZM19828@torch.brasslantern.com>
On Thu, Mar 5, 2015 at 2:57 AM, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Mar 4, 7:40pm, Mikael Magnusson wrote:
> } Subject: PATCH: Don't store ZLE_LINE_ABORTED in vared context
> }
> } send-break (^G ESC-^G) (unbound) (unbound)
> } Abort the current editor function, e.g. execute-named-command, or the
> } editor itself, e.g. if you are in vared. Otherwise abort the parsing
> } of the current line; in this case the aborted line is available in the
> } shell variable ZLE_LINE_ABORTED.
> }
> } However, pressing ctrl-c inside vared stores whatever was being edited
> } in ZLE_LINE_ABORTED, which the above seems to imply should not happen.
>
> Another documentation error rather than code error, IMO.
>
> } The following adjusts the code accordingly. It was actually a bit
> } annoying if you set up a widget to do the up-line-or-aborted, because
> } it will grab the vared text as a command then.
>
> Hrm, perhaps, but I believe the intent was to be able to hang on to
> whatever buffer was most recently being edited when the interrupt came
> through.
So how should I handle this case in my shell widget then? I think pws
introduced the feature so maybe he can clarify. (I won't push the
commit in the meantime).
--
Mikael Magnusson
next prev parent reply other threads:[~2015-03-05 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 18:40 Mikael Magnusson
2015-03-05 1:57 ` Bart Schaefer
2015-03-05 2:41 ` Mikael Magnusson [this message]
2015-03-05 4:46 ` Bart Schaefer
2015-03-05 9:59 ` Peter Stephenson
2015-03-05 13:58 ` Peter Stephenson
2015-03-06 9:52 ` Peter Stephenson
2015-03-06 16:05 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3QbXZQqPJpd0Wxvx6pVjmCmiB=yQN5RmRfKXdbhUtCqnw@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).