From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18280 invoked from network); 5 Aug 2020 16:14:09 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Aug 2020 16:14:08 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=Sender:List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Content-Transfer-Encoding:Content-Type:To: Subject:Message-ID:Date:From:References:In-Reply-To:MIME-Version:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=qsqOEP3/adYTDa63PXqdDNaNpfinKgKGc+GYQPl2bGA=; b=QrajANTFtD7Hyn2tLcK1niGK/x CTXoouYXz7halOsyOnBA6Zre4ZI3g2sIETKjqvvkB/ECHQ6rn1D8lJnWJBODADO9qGYP2b2iLdFxC /7k/OkeNOLz6jGOxUEp7F+7H9ZRaXX3/EVwYcdTPZB6UBNueDydNzUh+rLS9fTkc5jwg55Ldx1PV5 MOKDME79py1LjJ5FUUEOo+Zio++WO+gVk2pvbJBdQz5A9gTk/XtUyC+A1rPpILuvlJfnXfbF2FXPC kG6EY9QfgrKytNTiYDM6VIlk0+lfqfKN6zccT4CJ79FjZQo7Qs9Sbz9d7toOAXb0nKHFktfn56ZpU AYUYS6+w==; Received: from authenticated user by zero.zsh.org with local id 1k3M3G-000Oex-Ak; Wed, 05 Aug 2020 16:14:02 +0000 Authentication-Results: zsh.org; iprev=pass (mail-il1-x131.google.com) smtp.remote-ip=2607:f8b0:4864:20::131; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]:45167) by zero.zsh.org with esmtp id 1k3M36-000Oe7-FM; Wed, 05 Aug 2020 16:13:52 +0000 Received: by mail-il1-x131.google.com with SMTP id e16so3163044ilc.12 for ; Wed, 05 Aug 2020 09:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=qsqOEP3/adYTDa63PXqdDNaNpfinKgKGc+GYQPl2bGA=; b=IGmZpdqU4RrXfL49MEvOoX5tiU2BubFXkOpkO3iLxwObLUlKrjExG28Ui7bF7yZ+Eh /ZxDuUH2HXNkPnw+w9AAH1QdMbOYzau6zLZyBXrJz8fDsd4UKzKX7vrjoHFQMuXPtQYO nJAEe23upjsxKPgJCWxNEap/Kyq8+sZXLxt/dqXQqGR/nEA/NzYxx8hYoFtbRcKwGZM2 z0pRKlyV3Ko+2UWVWExUiXgtpUmig/J+0Fsserf1H6GdHv0Uc7yQRkhxmW33Pdr71drv EU+WRvfBZLXTtodP+E9oGonI3ZgZMXlThcKqhLQDUuAXRQ1I+n9DfDAGliT39GsSKVg/ EspA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=qsqOEP3/adYTDa63PXqdDNaNpfinKgKGc+GYQPl2bGA=; b=IVKoM/u1SGgYuFKHmr4IS895kMAA8/IwNGWFOfiQsCQBlDfC5MS0IDPoVo+wY0JwHe 5Ce9WhWMV2a6NHmXe3e2RgiVZQufDEqaw5GyzLeYBOscE+iEG4+P8H5dy7z92EsDkeAn U9QihK1XZYeLQEDGPFWxDObxsWkcHjj6k4VASG8y7eZ4yhnR1K8U53UVEk0uVASAuA0u Nb7wwX6e8lpypYDcuL+nOCVlDjxy7OMy+jByJxLJGbXznrZn5xBxkIr2NdJdIQBrxNcs vbIxuTGEZD6d8T4KSrvx8TS6JyUFkmCy1pqUf1J9WArg2ffUdy/D9Dr1H/vvNaKdkFya yYtw== X-Gm-Message-State: AOAM5316Toyq6N547xeU3bZEtIpQgyCX4PsJsVhqsSqeYOqxndmvZP7E T4FwbZNj/9vUmawdc1fVLKj1gfUvxucelp7+CSovGg== X-Google-Smtp-Source: ABdhPJwEW4+SDv3dxJgPZ9n2cfTjzsmGJKoRhd09PwJYTSUbobCc6RcAAKq7oviJsPdG1QmFdIuvlIoH1KbVlD8o4g0= X-Received: by 2002:a05:6e02:803:: with SMTP id u3mr4599513ilm.219.1596644031064; Wed, 05 Aug 2020 09:13:51 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:f650:0:0:0:0:0 with HTTP; Wed, 5 Aug 2020 09:13:49 -0700 (PDT) In-Reply-To: References: <20200220190310.tms2xcwk3sjmqb76@localhost> From: Mikael Magnusson Date: Wed, 5 Aug 2020 18:13:49 +0200 Message-ID: Subject: Re: print -v with multibyte characters To: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 47297 X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Sender: Sympa Owner On 2/20/20, Mikael Magnusson wrote: > On 2/20/20, zsugabubus wrote: >> Hi, >> >> $ echo $ZSH_VERSION >> 5.7.1 >> $ export {LC_ALL,LANG}=3Den_US.UTF-8 >> $ set -o multibyte && echo ok >> ok >> >> Good: >> $ print =C3=96=C3=93=C5=90=C3=B6=C3=B3=C5=91 >> =C3=96=C3=93=C5=90=C3=B6=C3=B3=C5=91 >> $ printf -v var =C3=96=C3=93=C5=90=C3=B6=C3=B3=C5=91; echo $var >> =C3=96=C3=93=C5=90=C3=B6=C3=B3=C5=91 >> >> Bad: >> $ print -v var =C3=96=C3=93=C5=90; echo $var >> =C3=83=C2=B6=C3=83=C2=B3 >> $ print -v var =C3=B6=C3=B3=C5=91; echo $var >> =C3=B6=C3=B3=C5=83 > > This gets closer to correct, but seems to leave out the final byte or > two, or change it somehow, > diff --git i/Src/builtin.c w/Src/builtin.c > index 168bf8863b..ed26717b5b 100644 > --- i/Src/builtin.c > +++ w/Src/builtin.c > @@ -4848,8 +4848,7 @@ bin_print(char *name, char **args, Options ops, int > func) > if (ret) > free(buf); > else > - setsparam(OPT_ARG(ops, 'v'), > - metafy(buf, rcount, META_REALLOC)); > + setsparam(OPT_ARG(ops, 'v'), buf); > unqueue_signals(); > } > return ret; > @@ -4972,8 +4971,7 @@ bin_print(char *name, char **args, Options ops, int > func) > if (ret) > free(buf); > else > - setsparam(OPT_ARG(ops, 'v'), > - metafy(buf, rcount, META_REALLOC)); > + setsparam(OPT_ARG(ops, 'v'), buf); > unqueue_signals(); > } > return ret; > > Incidentally you can use print -v var -f %s =C3=96=C3=93=C5=90; echo $var= to work > around the problem (the handling for -f uses different code which > doesn't have the bug). Just looking through some pending patches and saw this is unresolved. Does anyone have any ideas on how this can be fixed? --=20 Mikael Magnusson