From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 10631 invoked from network); 30 Aug 2021 12:42:45 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 30 Aug 2021 12:42:45 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1630327365; b=b6rB240n+1HQNAIW3jsNxU7WVeDmw4vCsxlIB1Ih7p9nHAXrJCP1VaiUJ4wvaBdxmQCiNZD4Go w4le358Y7ZUUHGKaYV7/5aBM7arDH4WX8baaOV3P/ITwHOm98MgU0Z1WdgHIcgPXWdJf2Sm9tX /JVhnrspBFjRPPGJVAzuYqu0Y/jhqWCgS7QfGh2A7cmj1+1wH6JuzIA1FULzOfNixMuc1uxGpC 5nHPi7bdw1PprFcgiQUl7fRPnvagSJT+UyVybsdOKvTSewRSNEsODGLPaMFdXwzeprJYmKAc1X sbmtYKIkKYARGZ2JpScYbEXsh4l6W+k+dbabqiYo0nFYKg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-vs1-f45.google.com) smtp.remote-ip=209.85.217.45; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1630327365; bh=2443mDBHxNALeZbhPfUw/8rlQngywWTzoidns738ZF8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:References: In-Reply-To:MIME-Version:DKIM-Signature:DKIM-Signature; b=Y6Wsizg2UVi5BvqW5tMxoxvWlnBdGy7yot64ZqwZDggOToZjE0iRg83Vqta3lTt3GvaeTPmSvG qHvcxV5qlI5DRxmk3OBROy9Bbl7oG7p4nQTZF7O37MSpExP1N5ji2BxbqUIbT+6xmLDb+H39yA CXTdiSE6euIcVeGQ4SlD/UJiOA5ZK/GuVwyufzTLrBA7l/QvtwOVNvJ2cLYpHUbHW3BNCex7Zu 0cCrgElPlghNuc/ojWBq8gdCf195Z19igVd4vK+Y27N4zVNg7LB4h6n110StEcvOBvtIkrPwRv vpSH7l4gsAi/UkkETE4xDn7olztLJfDvyCjqsG8MzxYxXA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:References:In-Reply-To:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=l/fDC630EW1oDTrlSULr/diuz5HKpne9H4KCYVFT+yk=; b=bOfEDqn7MGZsieiDXHf0Vyecwa vtAmQSJ48kiPe5j2TvNkoh1cDM1gkw3YAlcRPil1YYEab7z5ImEYqCjdJPdAS6pckOD7iaHuaSQrM BKqOOmoiYTj3eIdm3EUnFbt5aOK34LCVECx1d8O/movrFWGoj1pQ3wsslgDtRRZ2TgwD4RidMj+fb UUcclrAknKC+mFQhHhx+8p+XHQapFUAwcSpJGwXYlD1nebYGOmwW6rPXNEgX0D4vZGMF3Mj8XrLt8 GTaDLhqdy+teJrI9VCn5iNsN6eD7/WeEVHHJtxoP6OIN5Ij5ckyb7nJAy5+3rQZrUecUAe0Z8Qo7Z q/Ui2yWg==; Received: from authenticated user by zero.zsh.org with local id 1mKgce-000NPn-H9; Mon, 30 Aug 2021 12:42:44 +0000 Authentication-Results: zsh.org; iprev=pass (mail-vs1-f45.google.com) smtp.remote-ip=209.85.217.45; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-vs1-f45.google.com ([209.85.217.45]:36422) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1mKgcN-000N79-4k; Mon, 30 Aug 2021 12:42:27 +0000 Received: by mail-vs1-f45.google.com with SMTP id f6so7808582vsr.3 for ; Mon, 30 Aug 2021 05:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l/fDC630EW1oDTrlSULr/diuz5HKpne9H4KCYVFT+yk=; b=Wmo6ZeemFDYLwhRKWU/nSc07VLCXv+Ty+sIOv8Eu6Crk2lP6uuLPIK652P6R5ADpKY nzzyIzZJQY/2ZROwNfx36XrLmpHUJLoYks6sUIziTRC06r8fkc9BRqH8wwBzRFubNH70 MsfsUdKrMJrZ2+MSSbBbaTKZbOI51b7TbhDJpm+RHZAuJax9CxaHHag4iHZ1c8k7EO27 j/6ZKEJckZGqYsJHihBDdLnT7GeypiKW9OZEu7/QsRs0uiVUrs+US6lIe97EL0kHm8pR WEFjjQ1zWek0M7MLo0j9wcuzzJxGxzBts+C043FjiZIE7BUvSc3E1ksYaQn1olXbj/Sm 0wxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l/fDC630EW1oDTrlSULr/diuz5HKpne9H4KCYVFT+yk=; b=i5IFL64RNQGMnP0yP9bUYZtVaiCd0YHQ6YAX7X7YNk06ssFZT6QoOd+5m6FYNsUVUr QjXxNg4G1JBoJ/Zt0GaOwOnbVWa76pLTxSvKZLnTeuZ+5iu2Kxgry88m3rkYu11LsKJM tO7D7y/jXCS2ZcK/35v03M2/1G61bcc87yNJO+i/Fd6lC6XbQqYEC/h3OLshzyGEeORo cMpVXwJkci1Wh3r5SvOVOSkoDn3EW8ZGNN1yRRryRM476wZdHAHC+5SLPXsRjZ0E+XNS 7IYzl67GbHf/FQ+yCJr5wc1msMDJLiJD+ZTt3gmVN9uHBC4Px1efyPyG/6kQEG2oyq8+ /moQ== X-Gm-Message-State: AOAM531VhJoRWcg40kFWs6RRzOO6YS5TaKEpLgsJfQuJauYhNT00xpR+ 5wpemfj4I3beVSrUwEqQ3nzio2r0OXGBPKX4s+U= X-Google-Smtp-Source: ABdhPJyOJcFvK2BlGu2F9hMlFZFLqSTnqpHbIyV9cAeD87uYv0txGR79G+ICxsMwuKGpMrdcgPAP5sHhtZwvBYo1D1s= X-Received: by 2002:a67:fa88:: with SMTP id f8mr741310vsq.16.1630327346181; Mon, 30 Aug 2021 05:42:26 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:60b2:0:0:0:0:0 with HTTP; Mon, 30 Aug 2021 05:42:25 -0700 (PDT) In-Reply-To: References: From: Mikael Magnusson Date: Mon, 30 Aug 2021 14:42:25 +0200 Message-ID: Subject: Re: [PATCH] Remove redundancies from `git` completion To: Marlon Richert Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49333 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On 8/30/21, Marlon Richert wrote: > On Mon, Aug 30, 2021 at 2:41 PM Mikael Magnusson wrote: >> >> On 8/30/21, Marlon Richert wrote: >> > By the way: Why is there a `(( $+functions[_git-XXX] )) ||` statement >> > in front of each function inside Completion/Unix/Command/_git ? Can >> > those be removed? >> >> They are there so that you can override their implementation easily. > > Is that documented somewhere? Not explicitly, afaik. > And for purposes of overriding, wouldn't it be cleaner to simply > supply all sub-functions as separate #autoload files? I don't think anyone is interested in maintaining 285 separate completer files for git :). -- Mikael Magnusson