From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21376 invoked from network); 19 Aug 2022 02:26:49 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 19 Aug 2022 02:26:49 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1660876009; b=dgBJhMvD/7f1imZZP80kcZ0gq72lqAri0jB6E812TrdRN9UND0+AHctP9Vm1oaUQ/LduilAbdE 2ClpJq/PHJkByfasX0pKcrrwvravZRzdIWf6KX/QiXnA9xE+HjLzg2mOWc8WUJUvsEVJ6oqMCt 3xkE8TJFDoCT8H5Hrp1OUg6zo12JJdszwF+1psuSSEFUaY6eW5szcVYBa8Rt6CZ4s8JZ4DBoJy wQBO+LyQHsOOqzXAaBoqcwo5/t6flsqGW2AKynS+e4r44eYbGj0Mf6aHPN/zOuLzZT/imj/OCD NG6kb7IJ3LSI5rQ1JBghJ08lZ0VNkOoYNyMopE2Aek3Mjg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-oa1-f54.google.com) smtp.remote-ip=209.85.160.54; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1660876009; bh=JN90iY4E35P5TIGDMqBooaM0bZxt9B275Kiym1+us08=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:References: In-Reply-To:MIME-Version:DKIM-Signature:DKIM-Signature; b=oKn9vyVpB3ibPLiBQB1kgY9PyuiR21UbqMKIxo4yyQ+weSxDRiVafWJp1Q/w6XeUtpWgtdpLHb k2zVUJ0Tess9+/Hr0affHsoNMzit3ni9TYe+7opp4+3AMeaTMugPa7CTnTrSK3hjqmEUeAhJpE gdKbi9v85JP74ROrp6tzBv1S7hVy9ArBXVfY/2Yn0nX0X+OwBpvqVH3+jn/xx+0wgBzL+UK4JM KZ0QWFlFkm+iaQnmLiJBfLbE8L4SavtQ1+4XL9e6jYVk4VbUj3ZU4tBsIuB0BPQcqaZnH9yNcS aYFbl47h9ETE4nt81OxORVe1MvajlVoIUp6WRBzwhstqAQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:References:In-Reply-To:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=+g2MFRROw3eD72iDwDJiUIqoaTlUakaIrYyge6Np7f8=; b=B9vZm0sTr8flYyi8CgZr70FJrM iZvQETQe2MOl4dn4Yb3382lITYwu4xTtU/OaEeNGDULUpbEf8HqZcUToWbSB212cLd0RaEiWraOuY cVSWcanFZoYRVwZIy+wVliUH5wfcE5JikTOV+bT64+PFkLA3Ak/nh14xYFWULj2xlC+wfuPurG/bK j3jv9Zp1ciWzZWTaZZBhXlb5hWibERvPXetvQQhvpcA2aLC3uft+fCkQWovWlIRiBhCDwndKT0iLQ vrLo66w8Ld4xfxvxiO1vBQb163xHNb8nvdFY0WTGibfAX5+f536+t+kcI0S09M06Qvy0cnjplaTxw 6yo3R1Tg==; Received: from authenticated user by zero.zsh.org with local id 1oOrii-00097U-Vk; Fri, 19 Aug 2022 02:26:48 +0000 Authentication-Results: zsh.org; iprev=pass (mail-oa1-f54.google.com) smtp.remote-ip=209.85.160.54; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-oa1-f54.google.com ([209.85.160.54]:42999) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oOriS-0008mo-Nc; Fri, 19 Aug 2022 02:26:33 +0000 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-f2a4c51c45so3825315fac.9 for ; Thu, 18 Aug 2022 19:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc; bh=+g2MFRROw3eD72iDwDJiUIqoaTlUakaIrYyge6Np7f8=; b=pbj8kaVMIVcc+Cr3J0G2ckn/7l8kicqTEx5lshFfi5rjiEdwZbbzPgSF2XjZGiijC5 9s7koBbgS60KXRndoKYferkDyQ9iAvd8944MD0WM29mHv7JcrckBmwqwGxbJHH1iGS2t 4+wEjCIQt/N73gRQTBSDkV6hhpTYut3e+8yYdl3tELeOWnjQcM5aihBq0OMDwsgS75CY ywd1i6Lz8trOWQ1btPSjlFOwIzusXg24xdilvwZ7bShRwkpML0zCxL9WfQN8NxODu12P /c8Lgx23SZdQXf9OmFaTJN6YfSH6ByIqS0byit5gl40IY3HpBZbzgFPP7tg8CqaKv+OJ hzmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc; bh=+g2MFRROw3eD72iDwDJiUIqoaTlUakaIrYyge6Np7f8=; b=oc+4ILyimEEH9zfsj9pQXgHxP73NkLm8nuCAYSq2f/6X2rmZ3jRAbA2TDYEQ3BYgKq acj56A8Y8QOQexBwsE6fXqSTXFW9Ku/Q9K2lmZxc2PkCt2+0RVAGl0PRndKmmV8smLh5 00TNgjX5T/Ux6WPqEoCl53zv4VZyB4K1ph26nY/evLF+teXQKS6HcArQr3rsKwi2+x6R g5BMaHeCH5/R6qp1stmCiRSxTbfUrP5DiBwLzKeSyZ5D0jjnh6fExFr5Q1JfgIS6M40/ kLXIvyRll+7XsKJWLLFvlLwhB3OYyHOS23uv+yJnyjn8cImo4jMCaaEcrjZU+Bd14CfY gXsA== X-Gm-Message-State: ACgBeo1jyswwMPXFMLiDRzdVwjWxWqou78mNv6zvdOAXx8P6t15/USqv wf4X3SfCG/I8FGKVvN9dHzykeZorKjbR+D010rg= X-Google-Smtp-Source: AA6agR5JYuXKLFr+czgEV8qNLW+TD23Ld6ox3W0fV4nehfxtU9ghLU+ZgOq8II973S9khJ88xWuCfuCOicGa2av5kAM= X-Received: by 2002:a05:6870:ea89:b0:11c:6ff4:c345 with SMTP id s9-20020a056870ea8900b0011c6ff4c345mr4235261oap.293.1660875991478; Thu, 18 Aug 2022 19:26:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a8a:1189:0:0:0:0:0 with HTTP; Thu, 18 Aug 2022 19:26:30 -0700 (PDT) In-Reply-To: References: From: Mikael Magnusson Date: Fri, 19 Aug 2022 04:26:30 +0200 Message-ID: Subject: Re: rsync completions To: Bart Schaefer Cc: Alan Orth , zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 50487 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On 8/19/22, Bart Schaefer wrote: > On Thu, Aug 18, 2022 at 11:08 AM Alan Orth wrote: >> >> A few months ago the zsh completions for rsync stopped working correctly. > > So if this is a problem introduced by those quoting changes in rsync > 3.2.x, then the rsync completion has to become version-aware, which I > see is what fish has done. >From what I can tell from https://download.samba.org/pub/rsync/NEWS#3.2.4 the change is specifically in 3.2.4 which seems extremely user unfriendly to introduce such a breaking change in a micro revision. > I'm not able to tell what ramifications this has when the remote > version differs significantly from the local version; it doesn't > appear fish is taking that into account, so perhaps it doesn't matter. > > A quick workaround for you, Alan, is likely to be > alias rsync='rsync --old-args' > > There might even be a clever way to insert --old-args into $BUFFER > only when completion has been invoked, but completion widgets don't > play well with "ordinary" line edits so I'm not going there just now. -- Mikael Magnusson