From: Mikael Magnusson <mikachu@gmail.com>
To: Eitan Adler <lists@eitanadler.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH] _gcc: Improve completer for _clang and _gcc
Date: Mon, 18 Jun 2018 14:37:41 +0200 [thread overview]
Message-ID: <CAHYJk3QpZ-TPGEH+L-6P6JXsQMDLOUf9pe1Ca_fJ6mArRhb7dQ@mail.gmail.com> (raw)
In-Reply-To: <CAF6rxgn=6tkUBXDum+zG7neKPW98P8iC6AT2mpbbzO8v0UzQfQ@mail.gmail.com>
On Mon, Jun 18, 2018 at 9:49 AM, Eitan Adler <lists@eitanadler.com> wrote:
> On 18 June 2018 at 00:44, Mikael Magnusson <mikachu@gmail.com> wrote:
>> On Mon, Jun 18, 2018 at 7:14 AM, Eitan Adler <lists@eitanadler.com> wrote:
>>> clang - add additional sanitizers
>>> both - add additional standards (basically, aliases)
>>> both - fix -flto
>>>
>>> Signed-off-by: Eitan Adler <lists@eitanadler.com>
>>> ---
>>> Completion/Unix/Command/_gcc | 22 ++++++++++++++++++----
>>> 1 file changed, 18 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Completion/Unix/Command/_gcc b/Completion/Unix/Command/_gcc
>>> index a552bb2db..9690df79f 100644
>>> --- a/Completion/Unix/Command/_gcc
>>> +++ b/Completion/Unix/Command/_gcc
>>> @@ -338,16 +338,31 @@ h8/300)
>>> ;;
>>> esac
>>>
>>> +local -a sanitizers
>>> if [[ "$service" = clang* ]]; then
>>> args=(
>>> $args
>>> - -flto -emit-llvm
>>> + "-flto=-[generate output files suitable for link time optimization]::style:(full thin)"
>>> + -emit-llvm
>>> "-Qunused-arguments[don't emit warning for unused driver arguments]"
>>> --analyze
>>> -fshow-column -fshow-source-location -fcaret-diagnostics -fdiagnostics-fixit-info
>>> -fdiagnostics-parseable-fixits -fdiagnostics-print-source-range-info
>>> -fprint-source-range-info -fdiagnostics-show-option -fmessage-length
>>> )
>>> + sanitizers=(
>>> + address alignment bool bounds enum float-cast-overflow float-divide-by-zero
>>> + integer-divide-by-zero memory nonnull-attribute null nullability-arg nullability-assign
>>> + nullability-return object-size pointer-overflow return unsigned-integer-overflow
>>> + returns-nonnull-attribute shift signed-integer-overflow unreachable vla-bound vptr
>>
>> Did you mean to add this list under the gcc case?
>
> No. Those are the list supported by clang. I didn't do a full audit,
> but gcc supports fewer of them. It may support more than the list I
> included, but this is not a regression.
>
> Its hard to test gcc since it just errors out with "/usr/local/bin/ld:
> cannot find -lubsan" when testing and I don't want to go down the
> rabbit hole of debugging that right now.
Well, you remove "thread" and add "memory" instead for gcc, and the
manpage does list all values supported by gcc.
--
Mikael Magnusson
next prev parent reply other threads:[~2018-06-18 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 5:14 Eitan Adler
2018-06-18 7:44 ` Mikael Magnusson
2018-06-18 7:49 ` Eitan Adler
2018-06-18 12:37 ` Mikael Magnusson [this message]
2018-06-19 5:27 ` Eitan Adler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3QpZ-TPGEH+L-6P6JXsQMDLOUf9pe1Ca_fJ6mArRhb7dQ@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=lists@eitanadler.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).