From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2682 invoked from network); 6 Nov 2022 05:16:47 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 6 Nov 2022 05:16:47 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1667711807; b=FwvoCJkJt1V2JMXY56Z4xbQybWUcNIiQG+tnrtlTknEncd55MPu7tEaXA6QD5CgQTsegD6fC9V tVoQeIoUkhN+sjen4HIm87nNbYCsifQg7ySkMTapdHGZWwqF3oCUaEBMog/Ov73dFnvjfocqox 6D16WmpkrGBgsK16zH870ILPET3YzZwWtB0fSHNmiB5yAHCBRDoVdHPfQ1osYERUO8Ffa7BtaC RxPQOYwr/M3IOoScGmx0AFhvW+m9uDx89Qlrrx0UUKpo+ZL1dmOdOULTFaZQUhofJXbBQY7u8V vmWpPCOMfMfb3R/kBmukhIKwYIFUVrbD2HcACChRe1Vg4w==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f42.google.com) smtp.remote-ip=209.85.218.42; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1667711807; bh=4ZElvXKJrsDoWFXSZfBCEYh31OLhShnjD0DcZRe8u24=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:References: In-Reply-To:MIME-Version:DKIM-Signature:DKIM-Signature; b=hbjUZhrzb18Y3dYObheQyqL59NfidWVlTS2R6aRCgPoWaDZ257aXqU5mep9cJlHz5t+64cTeY3 KlN9dLGlhyaisOH6u4lc2wKMaxmSuLtP9kTDUKHBReX3mCIG1PWYAwG7iVR9Zvcjj2EkWqFVDQ KQwU1OnQC6Y6etVM2lbk99G6E8rojylZ1rAoDgqZu37MjJlKcuXtLRMaibOOzr6zofmcha1qUn aludrVAvUVpXtL+wj52EeQSBgUKD4SKV/uSCf7V7D7OkZq/HFSfhTdsttsNStDrcDMO6gczb6f kdoEdAG+RMspsfI31jwu2ujuKyEq9E82dBsd4tGhaESsRA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:References:In-Reply-To:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=oHYxokCq3CQuU6FcXgR6DCVDr1ljMO/3jXetwbw/YiQ=; b=Knm2/hXn/m/nOld0UW3YELxyu0 g3A4P3XtKHHb7ZQ4urA6L5Mc9mURw24Q1s6IizPZnAed4rjVG5Ee9GdUnUh8ACLGLgxGx008FsiT6 7Vk/GRIEcDDVarF+WUObUrz7XHFfYl3UPluUeTWyFhdJH6+qDmHYJ1/QB79JCGD+U17dAjZvrVzGo wMm7PQfbwDO98LQs6rZ7YNw4oXculWPJDVqqyNAmBShMiUrbNVV7s6JyBg00ohEdu9hvSaIPGcsgc SKUUln8jGhxpNoXMEZLSX0GHyp49ZKP3KtBOzLk55vn17CvVH/e12cePn8gdw3Xbq2A+KuJZbW3uB dzHPX2sw==; Received: by zero.zsh.org with local id 1orY1W-0009JG-Tq; Sun, 06 Nov 2022 05:16:46 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f42.google.com) smtp.remote-ip=209.85.218.42; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ej1-f42.google.com ([209.85.218.42]:35370) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1orY0t-00091e-8G; Sun, 06 Nov 2022 05:16:08 +0000 Received: by mail-ej1-f42.google.com with SMTP id k2so22583944ejr.2 for ; Sat, 05 Nov 2022 22:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oHYxokCq3CQuU6FcXgR6DCVDr1ljMO/3jXetwbw/YiQ=; b=PQwZt1P33PXQms09ewFUVgdNeYBVZDmJnGU1WMnr6CpOjFFPSJtMZaX75Mq7vcJ764 NHDvcfWREZqlUotm6I2Vg6el+fyQpCxHC6SLE8e5aQaZBn5yMIVwxOhGRer5NnJdcbky qLc01vuEqml7dboOLaz4rj+7qNBXaGbTWQYcmZuWQSPEqilmzUOy9AhnrA2nVNeJDVtW 4oLhtaxGyr1XTshEfj6iU7IKVatNgoSp6OBOIDmJOsjrh8it/PiYpXTFHAMU5rOfem4N SmgI8eoDCDQJaHt187od57MRZzB+c5SvpxQZWS4+vXRT/mmggHJiSh+vjthl6gyJj6vp 3NzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oHYxokCq3CQuU6FcXgR6DCVDr1ljMO/3jXetwbw/YiQ=; b=B5whxjqm/ulVA9Go2cT8rIZxS0/Vp+miEWRUl/Uhv1I+IioV7oxymlSeW6SiU/cfOl /aF6re445QPJeGzBhTS+fAeIWj5p8R0CMiqBwR9ptaOAnVKUsQ4fhWjEH9hIkPtVQcMR tq4orYCcD4NXCB2b2L1l28G/8hbzHSHonEPXptU/XjdzZDixjmlXh5dlRwejIBFa2MN6 1EIre4eO0J1t1asqWQHYEIQcBuBwoRt/91pN8K8mN/GNzk6qNFfTKPYBbLHYc5nivNxV KrJZa8EyjyYZteR10MqYugdNUn7l7LDM+JJ+WgrtUH8PRY4dyutr3hxJBZfmytL/gaGR U5yg== X-Gm-Message-State: ACrzQf14aYtr1UBNxx+5hSgTcAzZ1atJKyFy+q6L5t+fP8vMuuzqmYNO SbNEs2040Psj/GGLXb6MXmw0LPHlLyu75DlAwqvU/vL3 X-Google-Smtp-Source: AMsMyM6NGVgjMzhF+E21GJKUh4J6RMo0+Y6eh152Px9mDRfG2Dm9z9LvClEZjWEoXm7vSHTvXysXYhmaTgdsywIbIkY= X-Received: by 2002:a17:906:8470:b0:7ad:aeda:f47d with SMTP id hx16-20020a170906847000b007adaedaf47dmr39919248ejc.139.1667711766159; Sat, 05 Nov 2022 22:16:06 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:906:2508:b0:7a6:9215:51b7 with HTTP; Sat, 5 Nov 2022 22:16:05 -0700 (PDT) In-Reply-To: <7b444142-00f7-4b03-be95-068b9b476c53@zentaur.org> References: <6d9ab07d-680a-f717-d9ba-8d3519311eb0@zentaur.org> <7b444142-00f7-4b03-be95-068b9b476c53@zentaur.org> From: Mikael Magnusson Date: Sun, 6 Nov 2022 06:16:05 +0100 Message-ID: Subject: Re: [PATCH} Re: I think I found a serious bug in zstrtoul_underscore To: Clinton Bunch Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 50881 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On 11/6/22, Clinton Bunch wrote: > I see now my mistake in the options segment of bintab, ":%" specifies an > *optional* numeric argument. Removing the % makes it fail correctly. > Which leads to the question why would there be an optional numeric > argument specification, but not a mandatory numeric argument specification? > > Though it did uncover a pathological case that caused a catastrophic > failure in zstrtoul_underscore. It doesn't check that s is null before > it starts trying to convert. I've attached the trivial patch. If we did this, it would make more sense to add the check in zstrtol_underscore which has more than one current user, however it is expected that functions like this crash on NULL, the standard library strtol (and most other str*) does this as well. -- Mikael Magnusson