From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: Modules that load but do nothing
Date: Thu, 22 Jan 2015 05:05:43 +0100 [thread overview]
Message-ID: <CAHYJk3QsG1HM8C-sY5LBPVo-1tJ8yud1EcAT0a5zDib9zfYjDA@mail.gmail.com> (raw)
In-Reply-To: <150121194138.ZM10468@torch.brasslantern.com>
On Thu, Jan 22, 2015 at 4:41 AM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> If you configure --disable-dynamic and then force modules to be linked
> by changing config.modules to "link=static", the build will create the
> necessary .a file so that the linking phase completes, and loading the
> module with "zmodload" will return a zero status; but it is possible in
> this case for some modules to load with no features.
>
> The plainest example of this is zsh/pcre, which will compile and link
> but fail the V07 test suite.
>
> Are there other such modules? zsh/regex and zsh/curses, perhaps? There
> are no tests applied to the latter; the former is tested in C02.
>
> I'd suggest that at least we do the following:
>
> diff --git a/Test/V07pcre.ztst b/Test/V07pcre.ztst
> index 3a65331..3c25be2 100644
> --- a/Test/V07pcre.ztst
> +++ b/Test/V07pcre.ztst
> @@ -1,6 +1,6 @@
> %prep
>
> - if ! zmodload zsh/pcre 2>/dev/null
> + if ! zmodload -F zsh/pcre C:pcre-match 2>/dev/null
> then
> ZTST_unimplemented="the zsh/pcre module is not available"
> return 0
I was trying to link zsh against musl the other week to test some
unicode 6.1 stuff, and ended up with a terminfo module that didn't
provide echoti or $terminfo. I haven't looked at any tests in relation
to that though.
--
Mikael Magnusson
prev parent reply other threads:[~2015-01-22 4:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 3:41 Bart Schaefer
2015-01-22 4:05 ` Mikael Magnusson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3QsG1HM8C-sY5LBPVo-1tJ8yud1EcAT0a5zDib9zfYjDA@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).