zsh-workers
 help / color / mirror / code / Atom feed
* Modules that load but do nothing
@ 2015-01-22  3:41 Bart Schaefer
  2015-01-22  4:05 ` Mikael Magnusson
  0 siblings, 1 reply; 2+ messages in thread
From: Bart Schaefer @ 2015-01-22  3:41 UTC (permalink / raw)
  To: zsh-workers

If you configure --disable-dynamic and then force modules to be linked
by changing config.modules to "link=static", the build will create the
necessary .a file so that the linking phase completes, and loading the
module with "zmodload" will return a zero status; but it is possible in
this case for some modules to load with no features.

The plainest example of this is zsh/pcre, which will compile and link
but fail the V07 test suite.

Are there other such modules?  zsh/regex and zsh/curses, perhaps?  There
are no tests applied to the latter; the former is tested in C02.

I'd suggest that at least we do the following:

diff --git a/Test/V07pcre.ztst b/Test/V07pcre.ztst
index 3a65331..3c25be2 100644
--- a/Test/V07pcre.ztst
+++ b/Test/V07pcre.ztst
@@ -1,6 +1,6 @@
 %prep
 
-  if ! zmodload zsh/pcre 2>/dev/null
+  if ! zmodload -F zsh/pcre C:pcre-match 2>/dev/null
   then
     ZTST_unimplemented="the zsh/pcre module is not available"
     return 0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Modules that load but do nothing
  2015-01-22  3:41 Modules that load but do nothing Bart Schaefer
@ 2015-01-22  4:05 ` Mikael Magnusson
  0 siblings, 0 replies; 2+ messages in thread
From: Mikael Magnusson @ 2015-01-22  4:05 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: zsh workers

On Thu, Jan 22, 2015 at 4:41 AM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> If you configure --disable-dynamic and then force modules to be linked
> by changing config.modules to "link=static", the build will create the
> necessary .a file so that the linking phase completes, and loading the
> module with "zmodload" will return a zero status; but it is possible in
> this case for some modules to load with no features.
>
> The plainest example of this is zsh/pcre, which will compile and link
> but fail the V07 test suite.
>
> Are there other such modules?  zsh/regex and zsh/curses, perhaps?  There
> are no tests applied to the latter; the former is tested in C02.
>
> I'd suggest that at least we do the following:
>
> diff --git a/Test/V07pcre.ztst b/Test/V07pcre.ztst
> index 3a65331..3c25be2 100644
> --- a/Test/V07pcre.ztst
> +++ b/Test/V07pcre.ztst
> @@ -1,6 +1,6 @@
>  %prep
>
> -  if ! zmodload zsh/pcre 2>/dev/null
> +  if ! zmodload -F zsh/pcre C:pcre-match 2>/dev/null
>    then
>      ZTST_unimplemented="the zsh/pcre module is not available"
>      return 0

I was trying to link zsh against musl the other week to test some
unicode 6.1 stuff, and ended up with a terminfo module that didn't
provide echoti or $terminfo. I haven't looked at any tests in relation
to that though.

-- 
Mikael Magnusson


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-22  4:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-22  3:41 Modules that load but do nothing Bart Schaefer
2015-01-22  4:05 ` Mikael Magnusson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).