From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: _ps1234, _date_formats: Complete strftime formats for %D{}
Date: Thu, 9 Jul 2015 15:53:53 +0200 [thread overview]
Message-ID: <CAHYJk3QtTSZTQKerhj2HWofSPsVvR1dxBc7L8npDVz+EgxD-ww@mail.gmail.com> (raw)
In-Reply-To: <21764.1436444277@thecus.kiddle.eu>
On Thu, Jul 9, 2015 at 2:17 PM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> This patch also fixes and improves other things like the positioning of
> numeric arguments for ternary expressions.
PS1='%(<tab> no longer tells me "--- number", how is this an
improvement? It now completes delimiters after PS1='%(3<tab> which I
would also not consider an improvement :).
There doesn't seem to be a way to get back to completing anything
after print -P %D\\\{ (pressing tab at this point just deletes two
backslashes for me, and typing more things does nothing). It's
probably not a common thing to do though, so if it's complicated then
don't worry about it on my account.
if [[ -z $compstate[quote] ]]; then
bs='\' # in patterns we use (\\|) widely as print -P handles backslashes first
fi
I find the placement of this comment a bit odd, $bs is about
accepting/putting a backslash in places where the parser wants, not
any backslashes that print ever sees.
Let's hope nobody ever tries to use print -rP.
--
Mikael Magnusson
next prev parent reply other threads:[~2015-07-09 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 0:36 Mikael Magnusson
2015-07-06 11:11 ` Oliver Kiddle
2015-07-06 14:17 ` Mikael Magnusson
2015-07-06 14:56 ` Mikael Magnusson
2015-07-08 14:02 ` Jun T.
2015-07-08 14:42 ` Mikael Magnusson
2015-07-09 12:17 ` Oliver Kiddle
2015-07-09 13:25 ` Mikael Magnusson
2015-07-09 13:53 ` Mikael Magnusson [this message]
2015-07-09 15:20 ` Oliver Kiddle
2015-07-09 23:02 ` Oliver Kiddle
2015-07-09 12:22 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3QtTSZTQKerhj2HWofSPsVvR1dxBc7L8npDVz+EgxD-ww@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).