From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35752-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 27529 invoked by alias); 9 Jul 2015 13:53:57 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35752
Received: (qmail 26217 invoked from network); 9 Jul 2015 13:53:56 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=Q536gWdt9aSztk6e5IP5836J/ZX3F0nVUr/SbWkqr+I=;
        b=yJYTrUGFgLUntPzFfa7rZC0rmNqEk7dlSEKb39zzXZ8zQXAoB2dviEc1nsqkUS04dt
         k2j8aWquDTw61ae5agkhJ+HlVekSIIjlNLy5lDDdoNfSq+Dx21FGoD3h10zsaq3VzbKY
         IhbHSOdNLmVPymyHcFNSuq4TAaVIq9QAGltP0j+neNXPdv5cfl/wFzCmVGzQdMmcT4yb
         yCTTTHZ4dXIcnb0b6Wi80h3pqNfd6CJ1RVOlugZYoPyw7+pJBysHVqYPXjeSbM2vAd8i
         ZEfUwFlY0Y5n6rrEWuxGUerq6uY8fsr04TkFbPiEOZxL1kGpZAImnqmzxyzpM7DG+uY1
         tsMg==
MIME-Version: 1.0
X-Received: by 10.107.133.234 with SMTP id p103mr27934864ioi.85.1436450033575;
 Thu, 09 Jul 2015 06:53:53 -0700 (PDT)
In-Reply-To: <21764.1436444277@thecus.kiddle.eu>
References: <1436143012-9243-1-git-send-email-mikachu@gmail.com>
	<4740.1436181110@thecus.kiddle.eu>
	<97E3F4A3-6951-4848-8711-B8BD609BA79D@kba.biglobe.ne.jp>
	<CAHYJk3R267MFUk0qqh3ftQ_1U3=c0Ekqztk5_CCcqD5mttfo+w@mail.gmail.com>
	<21764.1436444277@thecus.kiddle.eu>
Date: Thu, 9 Jul 2015 15:53:53 +0200
Message-ID: <CAHYJk3QtTSZTQKerhj2HWofSPsVvR1dxBc7L8npDVz+EgxD-ww@mail.gmail.com>
Subject: Re: PATCH: _ps1234, _date_formats: Complete strftime formats for %D{}
From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Thu, Jul 9, 2015 at 2:17 PM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> This patch also fixes and improves other things like the positioning of
> numeric arguments for ternary expressions.

PS1='%(<tab> no longer tells me "--- number", how is this an
improvement? It now completes delimiters after PS1='%(3<tab> which I
would also not consider an improvement :).

There doesn't seem to be a way to get back to completing anything
after print -P %D\\\{ (pressing tab at this point just deletes two
backslashes for me, and typing more things does nothing). It's
probably not a common thing to do though, so if it's complicated then
don't worry about it on my account.

if [[ -z $compstate[quote] ]]; then
  bs='\' # in patterns we use (\\|) widely as print -P handles backslashes first
fi

I find the placement of this comment a bit odd, $bs is about
accepting/putting a backslash in places where the parser wants, not
any backslashes that print ever sees.

Let's hope nobody ever tries to use print -rP.

-- 
Mikael Magnusson