From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Initialization of main keymap [redux]
Date: Sat, 7 Oct 2023 20:25:36 +0200 [thread overview]
Message-ID: <CAHYJk3Qu5T6PX7db0fE7ODJBDMVtRqD0XoTBDN6DVGj0L2BVrw@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7Y0aSdp_27josJzWXOwb_eaqajragSueE3TMK8c252BeQ@mail.gmail.com>
On 10/23/22, Bart Schaefer <schaefer@brasslantern.com> wrote:
> Here's an update to my patch from workers/50559. The patch herein
> correctly compares only the string to the right of the rightmost "/"
> and also always prefers $VISUAL to $EDITOR.
>
> Daniel proposed alternately in workers/50569 that we discard this test
> entirely and always default to the emacs keymap. I don't feel
> strongly about it but as it's currently broken for many cases of
> setting those variables to a full path, we should pick one or the
> other.
I noticed we still haven't picked one of these. I would personally
prefer the patch that removes the check (Daniel's), but either is fine
with me. Have we heard from anyone who depends on it selecting vi
bindings for them?
--
Mikael Magnusson
next prev parent reply other threads:[~2023-10-07 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 4:03 Bart Schaefer
2023-10-07 18:25 ` Mikael Magnusson [this message]
2023-10-07 20:02 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3Qu5T6PX7db0fE7ODJBDMVtRqD0XoTBDN6DVGj0L2BVrw@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).