From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30273 invoked from network); 20 Jan 2023 00:22:24 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 20 Jan 2023 00:22:24 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1674174144; b=BJhqVVOGMA4U/lh2PHmYd1p34y+XC6dSA2LBLxJG16FbiBcakGLdlcgig7eJWFq5cGLDafuArO Y9f/AMR1V+wwAJIVMGKacB2zp87NU2ApeYvY+genAMOdnuFfZlc91DD4Virmpq61PJjzK7pyMV FZdXLPTdvpQQaWQkHKhG4Ow0PblwUiGc/gj2sVTwbwH05sfmD6Q/XNlPnoObpZx0VmbGDcyHeh +20uI+quzpTmGTECT5QGEd/qU1chJtqx6xQ1Ay1GayDNYBQLqPlgDOuRUzr6rsg7eK7yqjFkgW Uq97uOmQ7ds9GMWDfQeTvjDU4Dd+QtJc5Bsmz5sg5mCzKA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f45.google.com) smtp.remote-ip=209.85.218.45; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1674174144; bh=1eTANrmnegR+UixxEFY9du+ZZZeTi2xBdJUA/yaEAE4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:References: In-Reply-To:MIME-Version:DKIM-Signature:DKIM-Signature; b=QD630Sad3+WE9EqFQ9cMPJulfD5nXyMy9P23feXdwTtdkLA3tIBPh7haG1usstPlaUpyYvNyiR KdltaCRXprBBwg6X2zK+knTbIEBOLwhmsG5PbjUe/zUg41UgtCSxlPuhzXv7dLEkNNhuoGs5oh DokmvmmjFcQl9nSfFks94z0VtaeRVvsXtFuFkOEJW5oSWe5EACibY3+yZqVh20FORPSTJ3xpqG u/N/1dmYlhg0PgbopUF1UP68Qhc1qikCU2bJ3tM4zfpSPVZ38UYC8m436IF5d3IG6am78bmXvG W8uhnj5lL+W2lbH5STOPLSR7/fh9GILIU+k4RRd9+fwnaQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:References:In-Reply-To:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=TO7UVs/KQYS1slo8YpqWTkA98HRL9CJgBYCpnTQ8nP0=; b=XX91MECTHmiwaWJs3tZ9T+Zush yeHDGnU4rtUDo564qucIVTqTkWsCXquAeEeoiwNtAVc3t1vPdYk6Wj5wsAg1m4T2HMWIeAQQf3P6r ej6giFUGUP2EDfCL6XdEQv7nRZMi1Pwr/y2SxULF9+MQV4yyRLyoZl9MnBuPBPnHfInzJAIa8k5u2 7fdrYtLyHH2iDOxnLCjNzrqecheX6d9/LF2OPDoOEH0rYBT3BGLgbQnCqbeyUqlJlTvk2EHFtMGdi qOYL2frc24QZxql2vCwZQ42bOqxh1Ha2AMYuuR+Lk5nKQEsAmgh1QifhN9Sjsc0/YNwLaWAKVkpfe SsfSWGEg==; Received: by zero.zsh.org with local id 1pIfAk-0000gY-US; Fri, 20 Jan 2023 00:22:23 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f45.google.com) smtp.remote-ip=209.85.218.45; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ej1-f45.google.com ([209.85.218.45]:33724) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1pIfAU-0000P0-Et; Fri, 20 Jan 2023 00:22:07 +0000 Received: by mail-ej1-f45.google.com with SMTP id tz11so10206319ejc.0; Thu, 19 Jan 2023 16:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TO7UVs/KQYS1slo8YpqWTkA98HRL9CJgBYCpnTQ8nP0=; b=Qp4xyssvb9QKcKd6DJjs8SAKjcTA/5sGL2ZZPq48UkbM5PGFMMR+kqPJ9nWs0k2SAF uAFSLu3jjDb1unwnTJ0bO4i9DaJ1DOzyr2nWBwUo83dKWRnQiLRGBiv686iTnPvMoLOf ypM54F5Pq65cG/+O3Pq828glwJ+7cAdq2tkn6lh7x3t2XUp2+sMP3cXaMR6MHawtFy4c A61vF89y3DJRIJsqDQGp83+q3plFy1E7UxvUhrjthM28nbyyQuXHmHjaxGBhxKmnUxbt Gr1iqqd7W18nJ8sJ25JFGGMzUb1t51cCM3ntyhRAA0Lt85BxSXwHyyaWCnO8OG6jq4bf /gYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TO7UVs/KQYS1slo8YpqWTkA98HRL9CJgBYCpnTQ8nP0=; b=baSIbvSkUzhcF6Bjn0CS+ivFBWm6bcuXRlYaqcLvnHUuRzJrxTyYAve01VHWSL/RUH STdINqhEJO5vpCxhBaCJIZjd+MmR3HJS4GrhlLNYXo08OhSrJRfLLLEzWPzH5qR8J3A5 YCVYnLE8QuyIVKHYZztUs9QeVNpQyC9JVcggEX+UQ9f6F2H0wgND+69lpq6Vo5XJq/Vg QsgRaCW8qchA2k9wqguzm6qvoJANsN0r8+rfmrYSW+uen9ogTJyptYK3H5bmqvd1Eai4 u4Azl8U4ZlLeMS30+4acyLqJKOLMaZyJ5LCS4xiSqgKy2jpLtnGds0kgJybEim2E9Kvt K/eQ== X-Gm-Message-State: AFqh2kptv32pPJIa9DriJOw4z434FbcmfMR/ppjBU8swD3eg1aiFLKqU D+arMnu49PBbhjT9A7I3pyGxSg4psdb+XG8A1fPM448N X-Google-Smtp-Source: AMrXdXvIyjMej0/hSXRlqrou711nckvdeZcEqQTve8DvzV803krUWIg4izRxnnPjduihetaLlJ4FgCk+ap18f8F95vk= X-Received: by 2002:a17:906:ae56:b0:86c:fe1:b97f with SMTP id lf22-20020a170906ae5600b0086c0fe1b97fmr1635227ejb.388.1674174125450; Thu, 19 Jan 2023 16:22:05 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a17:907:c606:b0:7cd:3b2e:124 with HTTP; Thu, 19 Jan 2023 16:22:04 -0800 (PST) In-Reply-To: <51171-1674163110.743900@w5-F.JofK.-02M> References: <36223-1672793943.791824@SLuG.9t5a.jH-P> <2468-1673042601.684998@j4zI.qkM4.yrwt> <51171-1674163110.743900@w5-F.JofK.-02M> From: Mikael Magnusson Date: Fri, 20 Jan 2023 01:22:04 +0100 Message-ID: Subject: Re: PATCH: support for italic and faint fonts from region_highlight To: Oliver Kiddle Cc: Zsh workers Content-Type: text/plain; charset="UTF-8" X-Seq: 51321 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On 1/19/23, Oliver Kiddle wrote: > Mikael Magnusson wrote: >> I didn't check exactly which of your patches caused this problem, but >> i'll reply here. > > Did you check without my patches because I can reproduce the problem > even with 5.8. I only checked in another terminal window I had open since some time ago and couldn't reproduce it there, I've also only started noticing very recently and quite often so it seems weird to me that it would have been present before... > There is, nevertheless, a patch for it below. > You'll still get the full highlighted line if you leave attributes on at > the end of the prompt but I regard all behaviour associated with doing > that as there for backward compatibility only. I was thinking we should > maybe add zle_highlight tokens for the editarea, messages and statusline > so that there are better alternatives to doing that. > > It is something of a curiosity that the following will give you a > highlighted line when it needs to scroll but not when run elsewhere in > the terminal window: > > printf '\e[48;5;189m\ncat\e[49m\n' This is probably because when a new line scrolls in, it is initially filled with the current background color. > Some more obscure terminals don't do this, not sure if that's a bug in > them. > >> not be. Similar artifacts sometimes happen when the completion >> continuation prompt is shown ("At Top: Hit space for more..."), and I >> also noticed in some circumstances when I hit alt-m to start menu >> selection, the selected entry is not showed highlighted until I move >> it once or hit ^L, but I don't have a minimal reproducer for those >> things. > > All the attribute handling in complist is very much completely separate > code that I haven't touched. The group descriptions do use prompt > sequences but it is otherwise mostly based on the LS_COLOURS compatible > format instead of using the zattr type. It is still certainly possible > I've introduced something there and, either way, a minimal reproducer > would definitely help. Also mention the value of $TERM, the terminal and > what OS/termcap implementation you have. My setup doesn't ever involve > the completion continuation prompt you describe, at least not at the > top. I've seen glitches in the completion display in the past so there > may be old lingering bugs. I'll keep an eye out if I can figure out some pattern to the other oddities, and try to come up with something minimal. I didn't mention my terminal for the first problem because it happened in every terminal I tried (urxvt, and xterm :). I'll make sure to mention these details next time though. Tha patch seems to fix my blue problems (but X04 is unhappy). Thanks! -- Mikael Magnusson