From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13724 invoked by alias); 7 Mar 2016 02:05:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 38107 Received: (qmail 11364 invoked from network); 7 Mar 2016 02:05:07 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=HuRAG7yZf4/kZzpOcbmajvshlbzr3S0ibZcpsIMx/NU=; b=BOMOKySiOjBuRqQ5L6dzuBz+LsuRYoM9QhxVZ5Ig6r7cfU4Qv/2p/eo+Kt5KI35fkM UreoPJplLPcWETtcpjNHZWFErHtdHE8R+rJvPP7WH9LMpiPg4nwDNFbPkHj3k48Ykr9Q kYwU//dx7EXCjoOnQ1wWGuWsCBEujDGFt3ETCS3Js7pE6VVXobQ8lFuOUxwDJWAilo83 VuZ6k3QzyfxeJkwEQZ4vgbzOZZJQj85Oz1gTvfckiL5qfe+HIejpRXfWNgATIlRYTHOS Dyqq4dL4rgKHBioZMVV2MQFHVJiLE46Iuyao+NHDUgYekqm4EyvFErwlxbB21BkZLZlp 1pUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=HuRAG7yZf4/kZzpOcbmajvshlbzr3S0ibZcpsIMx/NU=; b=BGi3G5jh7jir9a2A7Ulygfmt3o0kRoR08cj/dV+vfjIBM44zevW8JEkgwjlzi4mNL8 Ro22/vVh2pNB4q3gFZt3auG4memOie0PONOaNqpFE1D3gLnnyMlhQ/hzP782BsYyV9G1 p7Nq6NstS93CTBEBwvmZ8xE8WYSmSoeJf815wBsbMsY5j7JsSKCTLArL1qkwKLOEjYDX Vu6JDwEjq8u2WkUlbcC73Chz2LAgxe+504nJU92sL2vTNi8huFH7lCj1v2x5zEuCIG2x GKmXKAif9oNwIem5Xt7KnwQdQ5ewq+TuXF14zhziSPORfuqQJwqkQlk4ZWxG+Eo6HCwv 7WOg== X-Gm-Message-State: AD7BkJJKY2A77B3WSoQzKGhQYX6D1JiQQ3ZGRlkBYsjTby8higHxzDm/nqtxHmW6WwY+3hCGWRrCUjAzxo/33Q== MIME-Version: 1.0 X-Received: by 10.140.22.212 with SMTP id 78mr25989913qgn.77.1457316305556; Sun, 06 Mar 2016 18:05:05 -0800 (PST) In-Reply-To: <160306094154.ZM20831@torch.brasslantern.com> References: <20160226175937.GA22547@lorien.comfychair.org> <160226114511.ZM17604@torch.brasslantern.com> <8456.1456706752@thecus.kiddle.eu> <160306094154.ZM20831@torch.brasslantern.com> Date: Mon, 7 Mar 2016 03:05:05 +0100 Message-ID: Subject: Re: reverse-menu-complete re-starting completion on 5.2? From: Mikael Magnusson To: Bart Schaefer Cc: Zsh workers Content-Type: text/plain; charset=UTF-8 On Sun, Mar 6, 2016 at 6:41 PM, Bart Schaefer wrote: > Meant to respond to this a while ago ... > > On Feb 29, 1:45am, Oliver Kiddle wrote: > } > } Even before that commit I can reproduce a variant of the problem by > } starting menu completion with reverse-menu-complete and then switching > } to a forwards menu complete. > > Not surprising, really. > > } [...] I'm really not sure why we need to be so > } strict about the completion widget matching the last completion widget. > > The only reason I can think of is in case menu completion is invoked from > within a user-defined widget, or otherwise entered by a different widget > than simple forward/reverse menu completion. In that instance the user is > presumably not continuing with the menu in progress but instead wants to > start over. I.e. similar to tests of $LASTWIDGET in Functions/Zle/*. > > } anyone foresee any problem with just relaxing the condition (see patch). > > Maybe we'd need another flag action for "zle -f" to continue/interrupt a > menu in progress, but probably it will work as expected more often with > the patch than without. I suggest you push and we'll find out if a need > for a flag arises. I can tell you I quite often complete a directory name using normal completion, and then press ctrl-n to complete files inside by latest modification date. If this continued cycling directories instead, it would be quite inconvenient. But yeah, push and we'll see what happens to that. (I just now noticed that the other way around, switching from ctrl-n to tab already does continue the same cycle which is not a problem for me but seems slightly weird). -- Mikael Magnusson