From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: minor git completion tweaks
Date: Sat, 20 Aug 2016 00:46:38 +0200 [thread overview]
Message-ID: <CAHYJk3R4zYYePLbwLU265K2HzZdtD8-T1_MLh6FPHv5PBsNVEw@mail.gmail.com> (raw)
In-Reply-To: <70414.1471625341@hydra.kiddle.eu>
On Fri, Aug 19, 2016 at 6:49 PM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> This is just a few minor tweaks that were suggested off-list following
> last week's patch.
>
> Oliver
>
> diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
> index ac4c90e..f4011aa 100644
> --- a/Completion/Unix/Command/_git
> +++ b/Completion/Unix/Command/_git
> @@ -249,11 +249,7 @@ _git-bisect () {
> ;;
> esac
> ;;
> - (${(j.|.)~good})
> - _arguments \
> - ': :__git_commits' && ret=0
> - ;;
> - (${(j.|.)~good}|skip)
> + (${(j.|.)~bad}|${(j.|.)~good}|skip)
> # TODO: skip can take revlists.
> _arguments \
> '*: :__git_commits' && ret=0
Could this be (~j.|.) instead? Just in case someone defines good/bad
terms with a pattern character in them :). Also, should it be "git
bisect terms" above this, rather than just "git terms"? I only have
the former, on git 2.8.xyz.
--
Mikael Magnusson
prev parent reply other threads:[~2016-08-19 23:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 16:49 Oliver Kiddle
2016-08-19 22:46 ` Mikael Magnusson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3R4zYYePLbwLU265K2HzZdtD8-T1_MLh6FPHv5PBsNVEw@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).