From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27506 invoked by alias); 16 Aug 2011 19:48:03 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29692 Received: (qmail 17724 invoked from network); 16 Aug 2011 19:48:00 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.220.171 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Cj6naxY6xaAAgWTvOzmhxJfmZQS9vPaVr6s6jyGtuIM=; b=j1ZMY4E1x4DUa+fVcuk0ULbV0wj7ya/EGjc910X2wmCEbCNrR1KKD9SdpO7Gj2EXzr /UrSo4GylYUy62h9TN/oU/Q6NCKr3iLdQCdQhZc9Nc3K8T4p2nE8aruIHD/6+MPnsDL7 hXaIck3y2saf1uwT87RSWu7TdbLD3Rluo3OVE= MIME-Version: 1.0 In-Reply-To: <20110816183921.GA10577@derf.homelinux.org> References: <20110816183921.GA10577@derf.homelinux.org> Date: Tue, 16 Aug 2011 21:18:11 +0200 Message-ID: Subject: Re: [PATCH] Add completions for cryptsetup and twidge From: Mikael Magnusson To: Daniel Friesel Cc: zsh-workers@zsh.org Content-Type: text/plain; charset=UTF-8 On 16 August 2011 20:39, Daniel Friesel wrote: > Hi, > > could someone merge these into the repo, if they're okay? In _cryptsetup you don't redefine _cryptsetup() like you do in _twidge (it's better to redefine it to avoid redefining all the helper functions every time), and in _twidge you forget to pass "$@". -- Mikael Magnusson