From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Hahler <dhahler@gmail.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: BUG: failure in "vcs_info prompt" aborts precmd function
Date: Sat, 22 Nov 2014 23:20:59 +0100 [thread overview]
Message-ID: <CAHYJk3R81LhwfwxaDHRSMP0HZmbE7V3hrrn5Q4jGzRzBPRC=oQ@mail.gmail.com> (raw)
In-Reply-To: <5470CF7C.2000707@thequod.de>
On Sat, Nov 22, 2014 at 7:01 PM, Daniel Hahler <dhahler@gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 22.11.2014 18:51, Mikael Magnusson wrote:
>>> I am using a precmd hook to setup my prompt and call "vcs_info 'prompt'" from there.
>>>
>>> When starting an interactive Git rebase, while the editor is still open, it will fail as follows:
>>>
>>> VCS_INFO_get_data_git:208: no such file or directory: .git/rebase-merge/done
>>>
>>> While this bug can be fixed (I'll post a patch), I think it's still a bug that vcs_info aborts the precmd.
>>>
>>> Why is that?
>>>
>>> I have tried adding "set +e" and "|| true" before the call to vcs_info, but without success.
>>
>> http://www.zsh.org/cgi-bin/mla/redirect?WORKERNUMBER=33671 should fix
>> this already.
>
> Yes, it's likely to fix this, although it might not be necessary to replace that many occurrences.
> Also, I don't know if "$(cat ..)" is as efficient as "$(< ..)". Does it use a subshell, or is it optimized?
>
> Apart from that, I am still wondering why the error in vcs_info causes abortion of the precmd function?!
Passing a non-existing file to $(< is a fatal error, or whichever term
is correct here. I'm not sure if that's a bug or not since it's
documented to not be the case. (in Command Substitution,
The substitution `$(cat foo)' may be replaced
by the equivalent but faster `$(<foo)'.
)
--
Mikael Magnusson
next prev parent reply other threads:[~2014-11-22 22:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-22 17:13 Daniel Hahler
2014-11-22 17:20 ` [PATCH] vcs_info: test -f .git/rebase-merge/done before reading it Daniel Hahler
2014-11-22 17:51 ` BUG: failure in "vcs_info prompt" aborts precmd function Mikael Magnusson
2014-11-22 18:01 ` Daniel Hahler
2014-11-22 22:20 ` Mikael Magnusson [this message]
2014-11-22 22:44 ` Bart Schaefer
2014-11-23 19:02 ` Peter Stephenson
2014-11-23 19:38 ` Bart Schaefer
2014-11-23 20:04 ` Peter Stephenson
2014-11-23 15:58 ` Daniel Hahler
2014-11-23 18:08 ` Mikael Magnusson
2014-11-23 19:57 ` TRY_BLOCK_ERROR and exit status Bart Schaefer
2014-11-24 10:11 ` Peter Stephenson
2014-11-25 8:01 ` Bart Schaefer
2014-11-25 9:18 ` Peter Stephenson
2014-11-23 18:13 ` BUG: failure in "vcs_info prompt" aborts precmd function Bart Schaefer
2014-11-23 18:52 ` Mikael Magnusson
2014-11-23 19:47 ` Bart Schaefer
2014-11-23 22:03 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3R81LhwfwxaDHRSMP0HZmbE7V3hrrn5Q4jGzRzBPRC=oQ@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=dhahler@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).