From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH] _git: Respect tags for subcommand completion.
Date: Tue, 23 Dec 2014 02:33:29 +0100 [thread overview]
Message-ID: <CAHYJk3R9Rmh06=bjgziRpc=xEBk-J5yMkuuM6YAZhFuRD9DhFw@mail.gmail.com> (raw)
In-Reply-To: <18765.1419294458@thecus.kiddle.eu>
On Tue, Dec 23, 2014 at 1:27 AM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Mikael Magnusson wrote:
>> > Attached a patch to improve the 'git <TAB>' user experience.
>>
>> Could you write a few words about what the patch actually does? Eg,
>> what's wrong with the current status quo?
>
> Did you perhaps not notice the subsequent text in the lead up to the
> patch?
>
> The current code is not using a single tag loop for all of the different
> types of commands. The default behaviour won't change much but with
> the tag-order style, you will be able to reorder the commands or have
> certain types only completed if others don't match or if _next_tags is
> invoked.
I did see it, but I didn't understand what difference it would make
since I already successfully use tag-order with _git. I see now though
that it only works because I hide some tags, I don't reorder anything.
(eg, with the - '! plumbing-blabla' syntax).
--
Mikael Magnusson
prev parent reply other threads:[~2014-12-23 1:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 20:45 Daniel Shahaf
2014-12-22 22:04 ` Mikael Magnusson
2014-12-23 0:27 ` Oliver Kiddle
2014-12-23 1:33 ` Mikael Magnusson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3R9Rmh06=bjgziRpc=xEBk-J5yMkuuM6YAZhFuRD9DhFw@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).