From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34047-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 9814 invoked by alias); 23 Dec 2014 01:33:33 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34047
Received: (qmail 3198 invoked from network); 23 Dec 2014 01:33:31 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=0ZFuKqJWq6YuK/uQF86Le70ibUyXTYYhx9c+nmg2cUY=;
        b=BmXwLWxzYu2442gk46oRiSTJFn7Fy3A+khbNqoThv+VRpLljWT2SoOnXxbAt2xfQjs
         a34fd15KwdsyCI3ddd+cAbLFU+mZbGLIjlgo5+djz28oO77VF7mhzl1sCvP9JFHiOOQC
         aCfrJmX66vP5puPN9docA3m9G/pQyl69rcLc1YgoTH/xHCJdavbcgqo4ReY8YZtjTnjj
         hbny86wojTbZvewqM+N2qdY+iC40UkFuqjTVX+fEetGtbOL0IajL4Q+p8QfppGDsSGDx
         POaux+pi60xF6galshr9TsCmEP+3zGo7DVe4eoG4yIKvg8VNGImsM00PyY4OpcvEEnl/
         RzCA==
MIME-Version: 1.0
X-Received: by 10.42.25.144 with SMTP id a16mr20480863icc.66.1419298410027;
 Mon, 22 Dec 2014 17:33:30 -0800 (PST)
In-Reply-To: <18765.1419294458@thecus.kiddle.eu>
References: <20141222204546.GC15399@tarsus.local2>
	<CAHYJk3Q7Y2kF8tGvg_BnAVmjtFEy41oFTz1tbqUex=kqQ7JPnw@mail.gmail.com>
	<18765.1419294458@thecus.kiddle.eu>
Date: Tue, 23 Dec 2014 02:33:29 +0100
Message-ID: <CAHYJk3R9Rmh06=bjgziRpc=xEBk-J5yMkuuM6YAZhFuRD9DhFw@mail.gmail.com>
Subject: Re: [PATCH] _git: Respect tags for subcommand completion.
From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Tue, Dec 23, 2014 at 1:27 AM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Mikael Magnusson wrote:
>> > Attached a patch to improve the 'git <TAB>' user experience.
>>
>> Could you write a few words about what the patch actually does? Eg,
>> what's wrong with the current status quo?
>
> Did you perhaps not notice the subsequent text in the lead up to the
> patch?
>
> The current code is not using a single tag loop for all of the different
> types of commands. The default behaviour won't change much but with
> the tag-order style, you will be able to reorder the commands or have
> certain types only completed if others don't match or if _next_tags is
> invoked.

I did see it, but I didn't understand what difference it would make
since I already successfully use tag-order with _git. I see now though
that it only works because I hide some tags, I don't reorder anything.
(eg, with the - '! plumbing-blabla' syntax).

-- 
Mikael Magnusson