From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Paulo Diovani <paulo@diovani.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [Bug] comparisson operator `[[` not working as expected
Date: Tue, 21 Jun 2022 02:47:42 +0200 [thread overview]
Message-ID: <CAHYJk3RA3KJ3+AQP0KrYLkq-z0nXL-fuROwz7X+MgsUhUd8VcQ@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7YnmfM3g6j9TB6NXHcFE7yTSY3-UG8wKg1OicwSgj3VZw@mail.gmail.com>
On 6/20/22, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Mon, Jun 20, 2022 at 11:33 AM Paulo Diovani <paulo@diovani.com> wrote:
>>
>> In version 5.9 the [[ ]] operator is behaving unexpectedly for the
>> following case:
>
> Yep, this is a bug, introduced when a different crashing bug was
> fixed. It's an off-by-one error skipping the first job in the table.
>
> The relevant ChangeLog entry for the crash bug is
>
> 2022-03-30 Peter Stephenson <p.stephenson@samsung.com>
>
> * 49906 (Bart), 49911: Doc/Zsh/builtins.yo,
> Doc/Zsh/mod_parameter.yo, Src/exec.c, Src/jobs.c,
> Test/W03jobparameters.ztst: Fix querying jobs in subshell.
>
> diff --git a/Src/jobs.c b/Src/jobs.c
> index e0e453ed8..25ceb81c4 100644
> --- a/Src/jobs.c
> +++ b/Src/jobs.c
> @@ -2402,7 +2402,7 @@ bin_fg(char *name, char **argv, Options ops, int
> func)
> int curmaxjob, ignorejob;
> if (unset(MONITOR) && oldmaxjob) {
> jobptr = oldjobtab;
> - curmaxjob = oldmaxjob ? oldmaxjob - 1 : 0;
> + curmaxjob = oldmaxjob ? oldmaxjob : 0;
Isn't this now just a very funny way to spell
curmaxjob = oldmaxjob;
?
--
Mikael Magnusson
next prev parent reply other threads:[~2022-06-21 0:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 18:32 Paulo Diovani
2022-06-20 19:54 ` Stephane Chazelas
2022-06-20 20:07 ` Paulo Diovani
2022-06-20 20:30 ` Bart Schaefer
2022-06-21 0:47 ` Mikael Magnusson [this message]
2022-06-21 3:42 ` Bart Schaefer
2023-05-03 18:17 ` Paulo Diovani
2023-05-04 5:38 ` Mikael Magnusson
2023-05-04 13:10 ` Paulo Diovani
2023-05-04 14:56 ` Bart Schaefer
2023-05-04 17:42 ` Paulo Diovani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3RA3KJ3+AQP0KrYLkq-z0nXL-fuROwz7X+MgsUhUd8VcQ@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=paulo@diovani.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).