zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Make yank zle params writable
Date: Wed, 30 Sep 2015 03:15:31 +0200	[thread overview]
Message-ID: <CAHYJk3RAEVdnAoRivDG8T2swkb-2bTwDYHZGct3W0yn34G6o4w@mail.gmail.com> (raw)
In-Reply-To: <1443501793-29753-1-git-send-email-mikachu@gmail.com>

On Tue, Sep 29, 2015 at 6:43 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
> Since these were added without much discussion, it seems a bit silly to
> add yet another interface (zle -f yank) to set them, so just make them
> writable.

I've thought about this some more, and I'm not sure which route to go,
wrt YANK_ACTIVE. It might be better to implement the zle -f interface
after all, if we find we do want to set other flags. If we had
YANK_ACTIVE writable then, we'd have two different interfaces for
setting different bits of the same variable, which might be even more
silly. I think I shall go the route of implementing zle -f
yank(before/after)/kill (I haven't seen evidence of others being
useful yet), and applying this patch (plus later amendments), apart
from the writable part of YANK_ACTIVE. It seems nobody else has strong
opinions about this, but sorry for going back and forth so much about
it :).

It probably also makes more sense to have a separate thing to set the
flag than to read it, since you're reading what the flag was before
entering this widget, but setting what it will be after it finishes.

-- 
Mikael Magnusson


  parent reply	other threads:[~2015-09-30  1:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29  4:43 Mikael Magnusson
2015-09-29  4:43 ` PATCH: Add a much simpler alternative to using url-quote-magic + bracketed-paste-magic Mikael Magnusson
2015-09-29 18:09 ` PATCH: Make yank zle params writable Mikael Magnusson
2015-09-30  1:15 ` Mikael Magnusson [this message]
2015-09-30  2:06   ` PATCH: zle -f from inside widget to set flags and make yank start/end " Mikael Magnusson
2015-10-01 15:33     ` Jun T.
2015-10-01 19:43       ` Mikael Magnusson
2015-10-02  8:09         ` Jun T.
2015-10-02 18:43           ` Mikael Magnusson
2015-10-02 19:58             ` Jun T.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHYJk3RAEVdnAoRivDG8T2swkb-2bTwDYHZGct3W0yn34G6o4w@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).