From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30706 invoked from network); 9 Dec 2022 15:18:06 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 9 Dec 2022 15:18:06 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1670599086; b=DzSbfwOrTGMSl8aebhPpsXXIUBezd2uTrofWKzzKxPsFhzY3+CMblaBUDhI8h4jO6AOgrkajoP kb3ZRvqT8N78YEoUlLX2xlBKa3LjXNdEEh97/KVEcUqPXPUGdjjqovQsoFCwtIt0wZ62XD0FaE a02RkNzwid7Ea6YtRv4x2hkxDGIMvUCcTE8JXBqURiGTWUXYweu9s/OShuGdpIFSEVSoRb5jGh p6EdWiLV6PrAPWzMILOvJ13vNb0LXQAmtRhNS+PKda0bugCbiNVjOsebNH/+L/t93RTTeTUcyi 653DBRQcmMnYVZDyf80nnlnTkJU7OW7xpfAsrRpBdrmjlw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f44.google.com) smtp.remote-ip=209.85.218.44; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1670599086; bh=RUqRZ0js+Tl9RGm8WBlvszWivNBiW7gn8a3Egk63kxk=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:References: In-Reply-To:MIME-Version:DKIM-Signature:DKIM-Signature; b=WVoi2mIYrdHzzDNfza78vs8D3xVSmLF7xCItbO06I8zcaSR8SV1NO41+1awaN5N6vLLvtyqxaH NlR6NsXpbOxhU6B52D2PY/9J+POpfZw/KInCNPT5ENBfS5f5XYe6G8aHEFVU9F49eB6Mc7cfWl 9bnR5icRWQ0wwyGRhGwmmTuqGha7l4d5F0FI0RAtauaxJxjizhdJm/lXZZejlhp3trEjNkMgLv m+6dSjLKenyGjhyXt2WEAm2jm9xI/hNBcsY4X4twmdJeC6g2GRWwY5kBlMZg0qMQNqW1DiabDY LBIgRoJj+mxCYtvgEMAX1esW/NzLPbiVPLGAVIrDR0QpzQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:References:In-Reply-To:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Qa9Nq47bn+pv8wjSemDneC8OtiYw/ioTjhprb6xfc9k=; b=seRuggLGhxTI28p7rhYTLd8Yqo OQfovKVmXn350uAlIiE9toWZYJahsP9MDk2tumou3V904/Tl43pTa8XOvljwr535N8lg0PEy/HtU3 os5WzR0HzwmcSKfvDognh3hH9j8t2gLe7qbLneex4jiw9sGmlebkBCjUvJ7C6CiYNva4Mm/zq5l3m auNce/M6GhP2bFcVV2NKFu0LBMmNzWfHwNAevUnoz5V9/l1c+a2nBHfykPRe+dn1aAxCo6V9sek9v Ne7saJgBtU8Q31nvf+WJW5+rFp7Dqx+7mdatuNwO+OYQ8cM5TZBmI8XOK+harvajVWMqU+HN7sbLv gr4IMwqw==; Received: by zero.zsh.org with local id 1p3f8X-000ApO-Lh; Fri, 09 Dec 2022 15:18:05 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f44.google.com) smtp.remote-ip=209.85.218.44; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ej1-f44.google.com ([209.85.218.44]:42891) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1p3f7z-000AVc-K5; Fri, 09 Dec 2022 15:17:32 +0000 Received: by mail-ej1-f44.google.com with SMTP id n21so12202863ejb.9; Fri, 09 Dec 2022 07:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Qa9Nq47bn+pv8wjSemDneC8OtiYw/ioTjhprb6xfc9k=; b=oSnyZuUyi/kuP/XggTcv4MDXq10X2XX2kWstmHhw7VAnAG3tT/yDKZSEz35Jq0/yPz q5B/C7idhc/etp5keO3eH1gTK8xL7YFWYL/FJxh3bZAfQry3W49G65a1lyAbJYGxsTvF SeHo3PrQOK6SZVvykqukYjvGyPAeAp+PjK6eEinhPpRKhKGYX9Ae9ksap+Xq40w5sCh4 uekC2w03utnKnjnLgZ0NmGb2zAHDKJS9Q19J4HMV0xu5xDG335OZSKS7tGz9S3uYHvtZ +Xk+OUVVWtRwq1nF613HnkFFb2Ivtdik7pM5UKn7Pv2DNjTSmzE6hTRYR3ZaY4KnCBxC MJNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qa9Nq47bn+pv8wjSemDneC8OtiYw/ioTjhprb6xfc9k=; b=kQpmi3sarSk8ivfxAoiW1QXv61zQkb0yELArKJcovTPbcCMbslv5yqG+k2mj3ebX/m RfMdk3qzeOjHREukC65K6tO3NRpkMYvVIoLYhYmiHXB56uWPdKoANdoi95ZXQCPSn0dt c22S78e9AD+uAtZPEQjVNwK2skBpl66d+pXygHMqlWo9B8JbK8yFxYVIdCnVMVK911md +FAi05TMblUkQB/fHg2+Sj/bBwkJImHGeaK+c1U36EgUzen80coMVI/+0fQoQAWEkoJC jQedqM7kcx59K/HlIc9vqhPFUBP8Wi2bFMokZLorrOzZds+yXwgz6UAlBozbz7yB4uCP nBAg== X-Gm-Message-State: ANoB5pkLtlgfa8iKsSCiSQ4XWOKumKQ/I0oDHSiEjchcEmmc/VwVry7H JiwlwKVHYVYjOOhIQBrpboM86LdncHpZLRy2P6w= X-Google-Smtp-Source: AA0mqf5XTtx05zjZMcS9wB435KdRtTTcDUBS6NpGykrTC7zrvZLEPjE9YOjT/Fl6khaah3Y8anQZRuvxZOOGYlRbbVQ= X-Received: by 2002:a17:906:ef1:b0:78d:260d:a6e4 with SMTP id x17-20020a1709060ef100b0078d260da6e4mr78004228eji.93.1670599050642; Fri, 09 Dec 2022 07:17:30 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a17:907:86ac:b0:7bb:1f4f:7625 with HTTP; Fri, 9 Dec 2022 07:17:29 -0800 (PST) In-Reply-To: References: <46fcb939-0ed9-4b51-959d-67339181e3e3@app.fastmail.com> From: Mikael Magnusson Date: Fri, 9 Dec 2022 16:17:29 +0100 Message-ID: Subject: Re: [PATCH] NEWS item about the ERR_EXIT fixes To: Philippe Altherr Cc: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= , Bart Schaefer , zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 51154 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On 12/9/22, Philippe Altherr wrote: >> >> I think it's overly verbose; NEWS doesn't have to explain how >> ERR_EXIT works. Here's a possible alternative: > > > Overall looks good to me but see comments below. > > + - Function calls, anonymous functions, and the `eval`, `.`, and >> + `source` commands no longer propagate ERR_EXIT suppression. > > > This kind of suggests that these constructs always propagated the > suppression, which isn't the case, but the exact circumstances look too > complex to explain. Maybe replace "no longer" with "now never". > > >> +The ERR_RETURN option is now suppressed when a function containing >> +a compound sublist (`&&` or `||`) is called from within another compound >> +sublist. > > > I find this a bit cryptic. It may also give the wrong impression that > functions containing a compound sublist are a special case. And finally, > the same is true for functions called in if/while conditions. Here is an > alternative: > > The ERR_RETURN option is now always suppressed on the left of `&&` and `||` >> (now even in commands within functions called from contexts where >> ERR_RETURN is suppressed). > > > The part in parenthesis gives a hint on what changed but maybe that could > be left out. As the context for the first hunk in the original patch says, README has a longer section about incompatibilities already, perhaps any more detailed descriptions as to what changed can be appended there? -- Mikael Magnusson