From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6103 invoked by alias); 10 Jun 2016 18:54:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 38654 Received: (qmail 3776 invoked from network); 10 Jun 2016 18:54:45 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/msyhSGzjh1HXySfs9Or2250EBIAhBFlY9KidAksQDk=; b=uYq5hWnQIbK2qVrWoByPQByA6ighIVu+jV8/ttWszC91TpaLaCnOkox0hjRHshAovY AhoswSBSq+enRzoKux+0HlKdWfpIF1FeBke4cosEnblCPHWwFjov7fhz37nAs4zvRwrz dk8JGhMJGB/WsipcJaWqXOh7YDu6md9zUvOTtv9t5rYdQZuIMInrushuQ3QgsIoeZUcE L358kX7ZTcaYZm+V2YryaarLVwRBAnurK/UKzbYlaB2qUmT1P7lCINfX7Ko1YB1reNLH HdEwjBxb2luBk9P6L9NRnmlMiO1TYMLncxwMRpF3WkoRp1cvMOlQHeOQWsL6asY+a8yx lDKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/msyhSGzjh1HXySfs9Or2250EBIAhBFlY9KidAksQDk=; b=HdJg1lE9zpOgHSZtAZvnmo0RTasfWr9IwTYpFovmZR87HGa7vrCndiAw5Fzt9VzGKp ZZ9E2d7Yob6FPR6mWCMCdW5HdjW9zKf8cDbQyPzOSVpgBQPk2VQoHCXRqMWL3E9rfbPZ 9DY+QvEZBvCVKs4k0vHOwVe8JAYti0gdAzaXLugu7kNNOsLC5KX6Jthj7uDFUJFZWNM3 LhARH4x9pL0FmB6IiExR8mRkNB+yV1ucBjfqSHHukd8nE6riJyl4PfgBs7HnW/vBKiPc UuDqIZbqakbj7MJekbZs1Yx7nfVGapeIRY0NteIt2xYAolxnx78pbxEdo7P+ojBCijdS yH6Q== X-Gm-Message-State: ALyK8tJmqCZxT7MDS4wEPLLVp42VvthlTkgQ7J6ldufpNeiS4/A4iLn3C115BCIGLgzi77m5OzbfPn+/l89jjg== X-Received: by 10.140.131.9 with SMTP id 9mr3424042qhd.34.1465584883890; Fri, 10 Jun 2016 11:54:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1465580184-3095-2-git-send-email-danielsh@tarsus.local2> References: <1465580184-3095-1-git-send-email-danielsh@tarsus.local2> <1465580184-3095-2-git-send-email-danielsh@tarsus.local2> From: Mikael Magnusson Date: Fri, 10 Jun 2016 20:54:43 +0200 Message-ID: Subject: Re: [PATCH 2/3] Fix the ':A' word modifier on paths with '..' components. To: Daniel Shahaf Cc: zsh workers Content-Type: text/plain; charset=UTF-8 On Fri, Jun 10, 2016 at 7:36 PM, Daniel Shahaf wrote: > The fix is to stop calling chabspath() at the top of chrealpath(). > > Also remove an incorrect comment (passing a non-absolute path would have been > fine because the chabspath() call would have made it absolute). > --- > > This is an incompatible change; see the test and docs changes for details. This seems pretty controversial, but I can see people wanting it either way. See for example the chasedots / chaselinks options, allowing the user to select which of these behaviors to use for the cd builtin. I don't think this should be pushed without more discussion at least. -- Mikael Magnusson