From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38443-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 18653 invoked by alias); 9 May 2016 13:04:29 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38443
Received: (qmail 26632 invoked from network); 9 May 2016 13:04:28 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc;
        bh=i/miHMonm3vQWuEFkUatlgyHMdPtKHGT1wa9WzkEXi0=;
        b=emFTmbuqLKjAnBnVD+GTj9yTTytr4CNFUazLM4j3uZAFM8pWcRblbORfFKOEIdw1oa
         VIWzTb9bTytyw43r+TKtfIE/pqvn07YF3ZRDbopA7w+F+clgNckkKB+5L/jfni+rgES1
         xKcRwgyLLJ3DAWh1d9RhWfLQ3oR40u7AzQrwNwld7J9Csn6BuPtXgTsi8+Kcr1MsC767
         ZDJu//akd5FfyotTKbjINKLBOPuuhOEvtChXBlNu2Jg5M0jja1hKPL4qsR1tPrnfN6AY
         MHICKDfbwT8YF1/B2IX8mzk3YuasuBq7DZNSTy/1cSYMn6CHNRRzDfOWtH9/fQPlI/R1
         zo4Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:cc;
        bh=i/miHMonm3vQWuEFkUatlgyHMdPtKHGT1wa9WzkEXi0=;
        b=P5kdureNabY7ms7kZNDFjwkuyfzhTEmhLKY97YBJG3L03SKd1LGZUchEnmMpnc6Jjf
         PWKeVLgoefSXuehXjLUFZ/1Lvq2QlAHSP87nvY4l2cjtlV/+5ZFdGmN/yNt2KXYIeAIU
         hRBWBwRIj7+6UBBQe7/2kyDv3dkPc3otF+PVLSf0MBXpJs5NVO3Cvj4MV6vaw9aqsv8W
         t5cgVoT0J3/xVxK+STurYzGYaLVjbEov+WI3RcK8TfPqOvUwNnOWUeMIIIkNzyuo+yON
         u8VJwvvsvu7s4/56hnHbriNtgNKL9RITt0Z4ygHJXOyitJLcM0EVOH2P4i/7ZaxKxkdy
         yVYA==
X-Gm-Message-State: AOPr4FX8xZnamhh98C9N/dQYc0P1IujmyVTGs8VP/zq0HrxVNG6c/gdAFPWyS8N3UAVVnyGxVpqmofrwrbnt9Q==
MIME-Version: 1.0
X-Received: by 10.55.99.214 with SMTP id x205mr36150825qkb.3.1462799065031;
 Mon, 09 May 2016 06:04:25 -0700 (PDT)
In-Reply-To: <57308891.6070906@redhat.com>
References: <57308891.6070906@redhat.com>
Date: Mon, 9 May 2016 15:04:24 +0200
Message-ID: <CAHYJk3RMavCDF0suqeMvxPHQLDVaiOYVxFwz_vuufqhwDy-=JA@mail.gmail.com>
Subject: Re: [PATCH] zsh x font family completion
From: Mikael Magnusson <mikachu@gmail.com>
To: Marko Myllynen <myllynen@redhat.com>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Mon, May 9, 2016 at 2:54 PM, Marko Myllynen <myllynen@redhat.com> wrote:
> Hi,
>
> I'm working on completions for a command which has an option to select
> the font family to use, I was wondering whether X font family
> completions would be worthwhile to add for others to use as well?
>
> Currently there's no any kind of caching, not sure would that be needed
> on modern systems? When I looked at x_font for inspiration, it had a
> big fat sign that its caching "*has* to be improved" so not sure what
> would be considered elegant or optimal here.
>
> Tested on RHEL 7.
>
> ---
>  Completion/X/Type/_x_font_family | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 Completion/X/Type/_x_font_family
>
> diff --git a/Completion/X/Type/_x_font_family b/Completion/X/Type/_x_font_family
> new file mode 100644
> index 0000000..48a1f23
> --- /dev/null
> +++ b/Completion/X/Type/_x_font_family
> @@ -0,0 +1,6 @@
> +#autoload
> +
> +local expl
> +
> +_wanted font-families expl 'font family' compadd "$@" \
> +  ${(f)"$(fc-list : -f "%{family|downcase|delete( )|translate(\,,\n)}\n")"}
>
> Thanks,

It would probably be less confusing if this was called
_fc_font_family, since X fonts are something else. This one should
probably not even be in the X/ directory.

-- 
Mikael Magnusson