zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: Bug: cd auto-completion of .. fails with parentheses in directory name
Date: Sun, 27 Nov 2016 19:30:07 +0100	[thread overview]
Message-ID: <CAHYJk3RPVw2HEM=e-T7f9hXSo3ZWZ=g+x=tuBsC_P0VAqro=aw@mail.gmail.com> (raw)
In-Reply-To: <20161127151706.GA9898@fujitsu.shahaf.local2>

On Sun, Nov 27, 2016 at 4:17 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Daniel Shahaf wrote on Sat, Oct 29, 2016 at 18:06:32 +0000:
>> diff --git a/Completion/Unix/Type/_path_files b/Completion/Unix/Type/_path_files
>> index 0d36b54..32942d7 100644
>> --- a/Completion/Unix/Type/_path_files
>> +++ b/Completion/Unix/Type/_path_files
>> @@ -594,7 +594,7 @@ for prepath in "$prepaths[@]"; do
>>      # There are more components, so skip over the next components and make a
>>      # slash be added.
>>
>> -    tmp1=( ${tmp1//(#b)([][()|*?^#~<>\\=])/\\${match[1]}} )
>> +    #tmp1=( ${tmp1//(#b)([][()|*?^#~<>\\=])/\\${match[1]}} )
>>      tmp2="${(M)tpre##${~skips}}"
>>      if [[ -n "$tmp2" ]]; then
>>        skipped="/$tmp2"
>
> I've reviewed the code again.  I believe that at the preceding
> 'compfiles -i' call, tmp1 is an input parameter containing a list of
> unquoted filenames, and is not modified by the call, so this patch is
> correct.
>
> Committed in eccb7471b577d55f0b410088fc1125016476b332, with a regression
> test.
>
> I'd add some reverse-engineered docs for bin_compfiles()'s -i case but
> I can't type right now.
>
> @all, please report breakage if any, with completiosn of oddly-named
> directories.

It still doesn't work for me, as before.

-- 
Mikael Magnusson


  reply	other threads:[~2016-11-27 18:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  6:12 Georg Nebehay
2016-09-22 14:42 ` Daniel Shahaf
2016-09-22 17:30   ` Bart Schaefer
2016-10-28  1:56     ` Mikael Magnusson
2016-10-28 15:10       ` Daniel Shahaf
2016-10-29 18:06         ` Daniel Shahaf
2016-10-29 18:39           ` Peter Stephenson
2016-10-29 19:44             ` Bart Schaefer
2016-10-31  3:22             ` Daniel Shahaf
2016-11-27 15:17           ` Daniel Shahaf
2016-11-27 18:30             ` Mikael Magnusson [this message]
2016-11-27 18:32               ` Mikael Magnusson
2016-11-27 18:39                 ` Mikael Magnusson
2016-11-28 19:30                   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3RPVw2HEM=e-T7f9hXSo3ZWZ=g+x=tuBsC_P0VAqro=aw@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).