From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35767-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 27728 invoked by alias); 10 Jul 2015 18:23:30 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35767
Received: (qmail 23769 invoked from network); 10 Jul 2015 18:23:28 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        bh=V+hoOOFzBGrv/FQ5zarqx57bjMpugbgzki1ClAyKgag=;
        b=l8pdkMual2lJJWGtFLTLSHiq0lqjtMXRVzcuH6XLpxeTm2N6vdp3Wm7vgR9DivbmDf
         WNL/0F3VOEPNOXm4P5dtytWok+CW376iGYeHGhS6v8EwP8fcHOaivX5Pn1qFAVdVgfQT
         z3ymnOLNOZ1HbgIrdsdkqr7ndvTQTINuVuNiYdDk4e7NAIdp17lpaLnxlQ/fPTiamkHh
         SewHrRE/ROTMGce0oZmQUta5IR/H/iG1Kppz6LDR5HqYUtDp3GMtH/3kXFN0qUsqRKt1
         vASowqMjiqCd/lErMNu2aVO5i+zxSnOowIIBvvtheQAoql8mRQnAJfDxHyXLfTRn/KMb
         x+wA==
MIME-Version: 1.0
X-Received: by 10.107.170.77 with SMTP id t74mr7224409ioe.107.1436552604516;
 Fri, 10 Jul 2015 11:23:24 -0700 (PDT)
In-Reply-To: <8ECA2924-1605-4DC7-B6AA-557705C04E39@kba.biglobe.ne.jp>
References: <20150709094122.17abacc8@pwslap01u.europe.root.pri>
	<1436435887-28736-1-git-send-email-mikachu@gmail.com>
	<8ECA2924-1605-4DC7-B6AA-557705C04E39@kba.biglobe.ne.jp>
Date: Fri, 10 Jul 2015 20:23:24 +0200
Message-ID: <CAHYJk3RWU1sEDr7-FyVB4fPM28QELqtQgnMG-0WvnUge5SA4BQ@mail.gmail.com>
Subject: Re: PATCH: ztrftime: Pass everything unhandled to the system strftime()
From: Mikael Magnusson <mikachu@gmail.com>
To: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 10, 2015 at 4:53 PM, Jun T. <takimoto-j@kba.biglobe.ne.jp> wrot=
e:
> V09datetime fails on Mac OS X, because the OS does not
> support "%04y" nor "%Ey" but only skip_extensions is set.
>
> mac% strftime %04y 1
> 4y
> mac% LC_TIME=3Dja_JP.UTF-8 strftime %OS 1
> 01
>
> I think these two skip_* need be set independently.
>
>
> diff --git a/Test/V09datetime.ztst b/Test/V09datetime.ztst
> index a7ef983..475adde 100644
> --- a/Test/V09datetime.ztst
> +++ b/Test/V09datetime.ztst
> @@ -8,13 +8,8 @@
>    unset LC_ALL
>    LC_TIME=3DC
>    TZ=3DUTC+0
> -  if [[ "$(strftime %04y 1)" =3D "0070" ]]; then
> -    [[ "$(LC_TIME=3Dja_JP.UTF-8 strftime %OS 1)" =3D =E4=B8=80 ]] || {
> -      skip_japanese=3D1
> -    }
> -  else
> -    skip_extensions=3D1
> -  fi
> +  [[ "$(strftime %04y 1)" =3D "0070" ]] || skip_extensions=3D1
> +  [[ "$(LC_TIME=3Dja_JP.UTF-8 strftime %OS 1)" =3D =E4=B8=80 ]] || skip_=
japanese=3D1
>
>  %test

Oops, yeah, I think I intended to check both of the parameters in the
second test case, then forgot. The idea is that only skip_japanese
can't be set, so I wrote the logic to enforce that. I'll commit this
as well to not print a misleading skip message if both are set.

@@ -34,7 +29,9 @@
 >6_6_3_3
 >000000

-  if [[ $skip_japanese =3D 1 ]]; then
+  if [[ $skip_extensions =3D 1 ]]; then
+    ZTST_skip=3D"strftime extensions not supported"
+  elif [[ $skip_japanese =3D 1 ]]; then
     ZTST_skip=3D"Japanese UTF-8 locale not supported"
   else
     (


--=20
Mikael Magnusson