From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Fix two bugs in typeset_setbase
Date: Sun, 3 May 2015 22:43:46 +0200 [thread overview]
Message-ID: <CAHYJk3RegjW5Q7JuHKH8=kKfkDRY5i1dZLtKQhUBH2bg1GCVaA@mail.gmail.com> (raw)
In-Reply-To: <1430685362-12270-1-git-send-email-mikachu@gmail.com>
On Sun, May 3, 2015 at 10:36 PM, Mikael Magnusson <mikachu@gmail.com> wrote:
> We refused to set the base outside [2,36], but this restriction should
> only apply to integers (where the base is actually the base). For float
> values, the precision can be anything. We also failed to actually enforce
> this limitation in either of these cases, but only printed the error
> message. We now only update the base if it was valid.
Perhaps we should apply some limit to the precision of floats? For example,
typeset -F 100000000 foo; echo $foo
succeeds, and at least in my setup, causes typing at the next
commandline to be very slow, because of multiple calls to
setunderscore(). It doesn't seem to affect zsh -f. This could also be
a case of "don't do that then". :)
--
Mikael Magnusson
next prev parent reply other threads:[~2015-05-03 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 19:21 'typeset -F' behaves unexpectedly for "-F 1" and "-F 0" David Hughes
2015-05-03 20:36 ` PATCH: Fix two bugs in typeset_setbase Mikael Magnusson
2015-05-03 20:43 ` Mikael Magnusson [this message]
2015-05-03 21:24 ` Peter Stephenson
2015-05-03 22:40 ` Mikael Magnusson
2015-05-04 2:34 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3RegjW5Q7JuHKH8=kKfkDRY5i1dZLtKQhUBH2bg1GCVaA@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).