From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35022-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 2520 invoked by alias); 3 May 2015 20:43:52 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35022
Received: (qmail 5874 invoked from network); 3 May 2015 20:43:51 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=eAemN9+qFr+QfsURyKXCPSDmCe1on9qJJsN+GpZ6Qy4=;
        b=sMBQaJw2wJzjP/a/nwamqPqy8hgzB+3BgKYziGgrPpnRdK8ERpYXBgLkE9aulkal89
         8sBNZwJlCLd8AY+kypVHd2a2hm0dMgXYDPZvWCTHzXAqv5Zq2HBE2Qi9oaGE7sAaVMf7
         ppfOKZ7YUh8CCvgRd/YI4CbsnxU64BwOfryu9+IsOeAxYD46m6CGPtC8fP6KwuFmR+wn
         5pDNRzmaqtf/nEimkZ7cBoBKIUwvSm6wjl9UTLEvXI0vnfdiPY/A7EZ8kI+GnOT4tipB
         QxI51b8e6irIpENrVmeEurco01fOY8St3Me+CZumTtL6N9KnauUVvX22xAAjKqBaMORy
         fNJA==
MIME-Version: 1.0
X-Received: by 10.43.18.194 with SMTP id qh2mr24776756icb.36.1430685826462;
 Sun, 03 May 2015 13:43:46 -0700 (PDT)
In-Reply-To: <1430685362-12270-1-git-send-email-mikachu@gmail.com>
References: <CAOcd6hrtTa7WVerarsU9+ZTWxa5G0g8f9Z+PGKCfMWZ7JWT-UA@mail.gmail.com>
	<1430685362-12270-1-git-send-email-mikachu@gmail.com>
Date: Sun, 3 May 2015 22:43:46 +0200
Message-ID: <CAHYJk3RegjW5Q7JuHKH8=kKfkDRY5i1dZLtKQhUBH2bg1GCVaA@mail.gmail.com>
Subject: Re: PATCH: Fix two bugs in typeset_setbase
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Sun, May 3, 2015 at 10:36 PM, Mikael Magnusson <mikachu@gmail.com> wrote:
> We refused to set the base outside [2,36], but this restriction should
> only apply to integers (where the base is actually the base). For float
> values, the precision can be anything. We also failed to actually enforce
> this limitation in either of these cases, but only printed the error
> message. We now only update the base if it was valid.

Perhaps we should apply some limit to the precision of floats? For example,
typeset -F 100000000 foo; echo $foo
succeeds, and at least in my setup, causes typing at the next
commandline to be very slow, because of multiple calls to
setunderscore(). It doesn't seem to affect zsh -f. This could also be
a case of "don't do that then". :)

-- 
Mikael Magnusson