From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <opk@zsh.org>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: support for italic and faint fonts from region_highlight
Date: Thu, 19 Jan 2023 17:22:09 +0100 [thread overview]
Message-ID: <CAHYJk3Rh-grjvTmjvmJXWy8d4vik_S82uH_EbTXDCOpkPvjoJQ@mail.gmail.com> (raw)
In-Reply-To: <2468-1673042601.684998@j4zI.qkM4.yrwt>
On 1/6/23, Oliver Kiddle <opk@zsh.org> wrote:
> It was brought to my attention that turning faint on does have a termcap
> entry - mh or terminfo dim.
>
> I've attached a replacement for this patch to use this which also adds
> a function for combining two attribute sets allowing for priority over
> colour and font weight to go to one of the sets. This will get even more
> use in the next update for handling leftover attributes from the prompt.
I didn't check exactly which of your patches caused this problem, but
i'll reply here.
% zsh -f
% zle_highlight=( default:bg=blue )
[hit enter until you're at the bottom of the terminal]
% cat
Now the whole bottom line is just filled with blue, which it should
not be. Similar artifacts sometimes happen when the completion
continuation prompt is shown ("At Top: Hit space for more..."), and I
also noticed in some circumstances when I hit alt-m to start menu
selection, the selected entry is not showed highlighted until I move
it once or hit ^L, but I don't have a minimal reproducer for those
things.
--
Mikael Magnusson
next prev parent reply other threads:[~2023-01-19 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 0:59 Oliver Kiddle
2023-01-06 22:03 ` Oliver Kiddle
2023-01-19 16:22 ` Mikael Magnusson [this message]
2023-01-19 21:18 ` Oliver Kiddle
2023-01-20 0:22 ` Mikael Magnusson
2023-02-08 22:52 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3Rh-grjvTmjvmJXWy8d4vik_S82uH_EbTXDCOpkPvjoJQ@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=opk@zsh.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).