From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: Bad effect of error in zle-line-pre-redraw
Date: Mon, 14 Nov 2016 12:15:43 +0100 [thread overview]
Message-ID: <CAHYJk3RksZBmE6gyLr+3HyvCEY+0Q481OStegoHtH6vtBW0Qtg@mail.gmail.com> (raw)
In-Reply-To: <161113105520.ZM18677@torch.brasslantern.com>
On Sun, Nov 13, 2016 at 7:55 PM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> On Nov 13, 3:45pm, Mikael Magnusson wrote:
> }
> } IIRC, and looking at the code, it needed to save more stuff around
> } calling the hook function. I think when I wrote the code,
> } zlecallhook() didn't exist, and the similar places I borrowed the code
> } from didn't have the errflag resetting. It does seem pretty likely
> } that restoring the errflag won't hurt.
>
> Well, zlecallhook() has been around since 2010 and git says that
> redrawhook() was 2015 ... but, no matter; how about:
Right, but it started life in my personal git tree earlier in 2010
than zlecallhook() :)
The patch looks fine to me, I wish I had added some comments about why
the additonal restores were needed... They kinda grew over the years
until it actually worked reasonably well.
--
Mikael Magnusson
next prev parent reply other threads:[~2016-11-14 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 17:03 Bart Schaefer
2016-11-12 17:54 ` Mikael Magnusson
2016-11-12 20:41 ` Bart Schaefer
2016-11-13 14:45 ` Mikael Magnusson
2016-11-13 18:55 ` Bart Schaefer
2016-11-14 11:15 ` Mikael Magnusson [this message]
2016-11-13 19:16 ` [PATCH] Widget fallbacks (Re: Bad effect of error in zle-line-pre-redraw) Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3RksZBmE6gyLr+3HyvCEY+0Q481OStegoHtH6vtBW0Qtg@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).