help / color / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: fix a memory leak and potential heap corruption when rotating lines
Date: Mon, 28 Oct 2019 12:50:43 +0100
Message-ID: <CAHYJk3RoOZj2zNZ1FE7oKNhG=+9nfLw3JFeRm7e2-Tb_EoNctw@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMou-FFjD5J0kxs6OLZq-GkUGztOUY-sOt3kL2uXQ_0n2Q@mail.gmail.com>

On 10/28/19, Roman Perepelitsa <roman.perepelitsa@gmail.com> wrote:
> I've bumped into this code accidentally while trying to do something
> unrelated. It looks wrong to me although there is a good chance I'm
> misreading it. I'm attaching a patch that either fixes two bugs,
> introduces two new bugs, or does something in between. I'll appreciate
> if someone more experienced can take a look at it.
> All test pass with this patch and my zsh seems to work fine. I haven't
> verified that this code actually runs either during testing or when
> I'm using zsh normally.

Did you accidentally sent a reversed patch? That line has been --olnct
since the initial cvs revision.

Mikael Magnusson

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 11:29 Roman Perepelitsa
2019-10-28 11:50 ` Mikael Magnusson [this message]
2019-10-28 12:04   ` Roman Perepelitsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3RoOZj2zNZ1FE7oKNhG=+9nfLw3JFeRm7e2-Tb_EoNctw@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=roman.perepelitsa@gmail.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link


Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git