From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34157-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 23633 invoked by alias); 7 Jan 2015 08:06:45 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34157
Received: (qmail 14710 invoked from network); 7 Jan 2015 08:06:44 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=86SmxtLm6bjinf+vUQxvoeGsGjVfOY+K0Mj05CPeNvM=;
        b=kkmRa7WiKxdMdyg1c8JM5NqQoEux+XCr03Hz3HtXmAiPda06MnwmoR8Wu86RFQcjw6
         ZxdqAe6noyAuoKaUiO6T/NP//G/t1hZb/kJXRu4Qc6uW4m3Y4M8BuRJzcTAWQt+bZcke
         jkK1NyX5eHLpVYb13jeB0ansDwG/86CMc49TFiw/JGEbhots2JViOVf7WN7gySNu+78h
         gBzAiX/VDL2e4pXOHMiFzTtm6nPHbXb7aupi65WZGaSEyQ4nhP+sFL3J1h0ut11tYJat
         2QiBofHVuaO66xh4ENfapjHNDs8ZSkqhpz5jRXEQnUJf0rNhGPija5cEkXCWmMFEFzaD
         wn6Q==
MIME-Version: 1.0
X-Received: by 10.50.109.164 with SMTP id ht4mr20805474igb.4.1420618002578;
 Wed, 07 Jan 2015 00:06:42 -0800 (PST)
In-Reply-To: <CAHYJk3S3R+A9O6G6JD64XPUOK=gRo8YPqYacc04V3Li3CPhBxw@mail.gmail.com>
References: <1420590318-17047-1-git-send-email-mikachu@gmail.com>
	<150106223532.ZM1050@torch.brasslantern.com>
	<CAHYJk3S3R+A9O6G6JD64XPUOK=gRo8YPqYacc04V3Li3CPhBxw@mail.gmail.com>
Date: Wed, 7 Jan 2015 09:06:42 +0100
Message-ID: <CAHYJk3S+dZkVBnHj7mC+QOS1BmQ01fY4oueHL9YF2jXmbbkxoQ@mail.gmail.com>
Subject: Re: PATCH: Plug some fd leaks in bin_print
From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Wed, Jan 7, 2015 at 9:04 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
> On Wed, Jan 7, 2015 at 7:35 AM, Bart Schaefer <schaefer@brasslantern.com> wrote:
>> This needs to be looked at more closely.
>
> Okay, I'll resend a version that just does the fclose when things are
> actually leaking, and leave the others alone. I didn't realize
> fflush()ing stdout was somehow dangerous sometimes.

I should have looked at all new mails before replying to this one,
oops, never mind :).

-- 
Mikael Magnusson