From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_ADSP_CUSTOM_MED,
	FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 18068 invoked from network); 5 Jun 2020 15:57:53 -0000
Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2)
  by inbox.vuxu.org with ESMTPUTF8; 5 Jun 2020 15:57:53 -0000
Received: (qmail 8456 invoked by alias); 5 Jun 2020 15:57:42 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45987
Received: (qmail 23486 invoked by uid 1010); 5 Jun 2020 15:57:42 -0000
X-Qmail-Scanner-Diagnostics: from mail-il1-f175.google.com by f.primenet.com.au (envelope-from <mikachu@gmail.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.3/25828. spamassassin: 3.4.4.  
 Clear:RC:0(209.85.166.175):SA:0(-2.0/5.0):. 
 Processed in 1.367409 secs); 05 Jun 2020 15:57:42 -0000
X-Envelope-From: mikachu@gmail.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.175 as permitted sender)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Mt/5O/c/kvVySfpx/V7qpQDMSD8kByhfpCNAPFELNVs=;
        b=snF1mloPyykf7Hr+T+CKPy1LaIJJ0xBBhYlcQcIpGECbjMDbwekGoOY7UhGXpOiVrW
         kkpTXpBKDLG58Vo0IlsO7fI8BYkMVGELZMKehU/idKoepJr7OTtLndIkgYT3xYYBhPMX
         roRn2pFS6IY0oa8uYgb3b9k2Wpk+T8Jea4/IUYp1nAyw1TIWPwrwdaVu+Jrd7V/Z9mnA
         KQh9DzeGOFExzAENGt1oCftlONr5rKwrf+KcECnHO9kULm4DZqf7t4IZHhgxQnGC/cSE
         PWcT6tPj4fCVvZ0qLd3o1eFREFiNWbq8PX88iJa3aJ1/oaTDa11/rxe+N+j+nvC1Jf5D
         5mMw==
X-Gm-Message-State: AOAM531QszVYfi/hvTcdyLx5lIOtOLGbRnVbDxhtr4hwO/xkNC2xFC/2
	00wLIuty2exEEXJUZpD1wkiBvv3qbqEB6RiVo9k=
X-Google-Smtp-Source: ABdhPJzw26q4QPwmpJc5hnNkPd20AhEMcq+37E/JaUSfio8SDTlqn0S6q8X+mOX2wfTRvtJCxCLOT5H3+7p60wflAEk=
X-Received: by 2002:a92:d112:: with SMTP id a18mr8845431ilb.3.1591372627931;
 Fri, 05 Jun 2020 08:57:07 -0700 (PDT)
MIME-Version: 1.0
References: <20200605134208.32082-1-mikachu@gmail.com> <650622554.469269.1591365499237@mail2.virginmedia.com>
In-Reply-To: <650622554.469269.1591365499237@mail2.virginmedia.com>
From: Mikael Magnusson <mikachu@gmail.com>
Date: Fri, 5 Jun 2020 17:56:53 +0200
Message-ID: <CAHYJk3S08BY-KB-PpvTRNpZR=WM-7bsJYz7KiWzB8mFXQw=xeQ@mail.gmail.com>
Subject: Re: PATCH: typeset: Fix leaving corrupted entries in paramtab
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Jun 5, 2020 at 3:59 PM Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
>
> > On 05 June 2020 at 14:42 Mikael Magnusson <mikachu@gmail.com> wrote:
> > This appears to fix the problem in 45984, but I would appreciate someone
> > checking if it seems sane and/or complete.
>
> Looks sane to me --- those are three cases where we've just created a new
> parameter for some special purpose (which then failed), which isn't typical
> in that function as it can operate on existing parameters too, so
> additional action at those specific points is correct.

Thanks for checking.

I thought about adding a test, but it'd only be possible to check for
these specific cases, and they'll only reoccur if someone removes the
code I added which seems hard to imagine. Similar bugs from other
flags wouldn't be found by the tests... so I opted not to add one.

-- 
Mikael Magnusson