zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh-workers@zsh.org
Subject: missing braces or wrong indent?
Date: Sat, 11 May 2019 20:04:44 +0200	[thread overview]
Message-ID: <CAHYJk3S1BTGRZTmeQha71mXu4k1+yqxtmMwWOTWJB4RAHa+AcA@mail.gmail.com> (raw)

Just submitted a new coverity build and looked at some stuff it was
unhappy about; this isn't one of them but what is going on here?

clone.c::bin_clone
55
    if (!pid) {
	clearjobtab(0);
	ppid = getppid();
	mypid = getpid();
#ifdef HAVE_SETSID
	if (setsid() != mypid)
	    zwarnnam(nam, "failed to create new session: %e", errno);
#elif defined(TIOCNOTTY)
	    if (ioctl(SHTTY, TIOCNOTTY, 0))
	    zwarnnam(*args, "%e", errno);
	    setpgrp(0L, mypid);
#endif
	dup2(ttyfd,0);


This/these if statements look completely bogusly indented, but maybe
it's also missing braces? I can't tell because I have no idea what it
wants to accomplish.

-- 
Mikael Magnusson

             reply	other threads:[~2019-05-11 18:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190511180553epcas2p2115461224eb064782dcff498f1b57b74@epcas2p2.samsung.com>
2019-05-11 18:04 ` Mikael Magnusson [this message]
2019-05-13  8:47   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHYJk3S1BTGRZTmeQha71mXu4k1+yqxtmMwWOTWJB4RAHa+AcA@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).