zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PM_ flags (Re: mikachu/badarrays ...)
Date: Wed, 7 Jun 2017 20:15:07 +0200	[thread overview]
Message-ID: <CAHYJk3S1wkU9qzi_o0ow2SdoxRTxT6bMHe1fpm==Y17aO25F3Q@mail.gmail.com> (raw)
In-Reply-To: <16943.1496832826@thecus.kiddle.eu>

On Wed, Jun 7, 2017 at 12:53 PM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> On 30 May, Bart wrote:
>
>> It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN,
>> the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID
>> and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do
>> double duty as they won't apply to arrays and functions at once.
>
> Should we perhaps change the flags field in struct param to be a 64-bit
> value to make room for more flags? Can we portably use something like
> uint64_t or is it not that simple?
>
> In addition to more overloading of function/parameter related flags
> there are also some mutually exclusive combinations. For example, only
> one of the PM_TYPE flags can be set so 3 bits could be used in place
> of 5 but it'd need the PM_TYPE mask adding in lots of places and only
> gain us 2 bits. There's also the 32nd bit available but to reliably and
> portably use that do we need to change flags to be an unsigned int?
>
> Oliver

Just to make this clear in case it wasn't, the flags I used in that
branch were only for debugging and not needed for the operation at
all, so there's no urgent need to fix this unless someone wants to add
another flag.

-- 
Mikael Magnusson


  reply	other threads:[~2017-06-07 18:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26  5:04 Valgrind testing, ideas Sebastian Gniazdowski
2017-05-26  5:50 ` Bart Schaefer
2017-05-26  7:57   ` Sebastian Gniazdowski
2017-05-26 10:56     ` Daniel Shahaf
2017-05-26 23:48       ` Bart Schaefer
2017-05-28 19:43 ` mikachu/badarrays (Re: Valgrind testing, ideas) Bart Schaefer
2017-05-29 13:21   ` Mikael Magnusson
2017-05-31  5:47     ` Bart Schaefer
2017-06-01 16:31       ` Sebastian Gniazdowski
2017-06-01 20:35         ` Bart Schaefer
2017-06-02  1:40           ` Sebastian Gniazdowski
2017-06-02 22:00             ` Bart Schaefer
2017-06-04  0:49             ` Bart Schaefer
2017-06-04  7:08               ` Sebastian Gniazdowski
2017-06-01 21:22       ` Mikael Magnusson
2017-06-01 21:38         ` Bart Schaefer
2017-06-07 10:53       ` PM_ flags (Re: mikachu/badarrays ...) Oliver Kiddle
2017-06-07 18:15         ` Mikael Magnusson [this message]
2017-06-07 22:18         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3S1wkU9qzi_o0ow2SdoxRTxT6bMHe1fpm==Y17aO25F3Q@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=okiddle@yahoo.co.uk \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).