From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 784 invoked by alias); 7 Jun 2017 18:15:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41251 Received: (qmail 3335 invoked from network); 7 Jun 2017 18:15:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-qt0-f173.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.216.173):SA:0(-0.0/5.0):. Processed in 1.751417 secs); 07 Jun 2017 18:15:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.216.173 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aVSm5dmXg//OnUUZ5LFdM1fFrQ3iWwueKgf7g0ZA1+g=; b=SOX5pP9bnsyTNwpoWeMPGWg3W7YVez+zYVps8twQM9wPxTv6HcWD0HcjJXQNOmmsKU 9BFPXyN/kOICyY6Px4c4vTRbpWxpyMn21K0eqGrVQHZ13iEyHBMmHjTcdz2MWPIXhBug SmhllKMWBYqVzuBV3cJ1Zi39uviAaASSBGsPhP/plFgHWhAlV7hQHEgROPGd3NRsfPmu g20ZbFpnsq6OkHVZEj989n896HHxXcNomTqe30g+1OjFFt93d2nQcpf8y4Rdlf8XNZvq XTDmQYGGVPmsL35/3qlGvmcJHcn70HVToQ1kgVgqbk2rGfw6Xg+LgVVILi6XrlwEZivz FpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aVSm5dmXg//OnUUZ5LFdM1fFrQ3iWwueKgf7g0ZA1+g=; b=EPDCN+vOFFT9ZiEUSVZg12kRDb34bZbMvWnD30ZkeTrlX86jmdOFxU86vw8Di+gOYr xdhn2RFAy57QHKHuPcMTPF1EXHfGqJBn5bZOb2Qt06S4zROAjJziwILjCKJ+eeEqlu+b lm7Hb1ssGlo4nCSs3cjh+BKap23VusyEQ0CAjo5AM5HtyS7wlGp/37QtHkGBUCGRapC7 nWLmFpm0TPe09nbs0O/VC3vrVAFXQozjzObY7AngzM/v7I1+YP7d7K2UWVb06+zyPMx8 QkuhhWJxwu75bOX/2JRKfUgMioPqBL2v2oHD4rBUt+0Lxxg8dLpkmNFfXUPEZIikHZqq xG7g== X-Gm-Message-State: AKS2vOxJFs+6BKaD05jqKXJ/2S3nAqvsj0WP8X9R9k4EHPNrbYOpy11s 8fpEvAf+8Q67qQNNUxsRFexKco/AgQ== X-Received: by 10.55.9.203 with SMTP id 194mr39561497qkj.20.1496859308106; Wed, 07 Jun 2017 11:15:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <16943.1496832826@thecus.kiddle.eu> References: <170528124337.ZM9444@torch.brasslantern.com> <170530224728.ZM25709@torch.brasslantern.com> <16943.1496832826@thecus.kiddle.eu> From: Mikael Magnusson Date: Wed, 7 Jun 2017 20:15:07 +0200 Message-ID: Subject: Re: PM_ flags (Re: mikachu/badarrays ...) To: Oliver Kiddle Cc: zsh workers Content-Type: text/plain; charset="UTF-8" On Wed, Jun 7, 2017 at 12:53 PM, Oliver Kiddle wrote: > On 30 May, Bart wrote: > >> It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN, >> the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID >> and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do >> double duty as they won't apply to arrays and functions at once. > > Should we perhaps change the flags field in struct param to be a 64-bit > value to make room for more flags? Can we portably use something like > uint64_t or is it not that simple? > > In addition to more overloading of function/parameter related flags > there are also some mutually exclusive combinations. For example, only > one of the PM_TYPE flags can be set so 3 bits could be used in place > of 5 but it'd need the PM_TYPE mask adding in lots of places and only > gain us 2 bits. There's also the 32nd bit available but to reliably and > portably use that do we need to change flags to be an unsigned int? > > Oliver Just to make this clear in case it wasn't, the flags I used in that branch were only for debugging and not needed for the operation at all, so there's no urgent need to fix this unless someone wants to add another flag. -- Mikael Magnusson