From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13174 invoked by alias); 14 Jun 2017 04:49:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41288 Received: (qmail 22940 invoked from network); 14 Jun 2017 04:49:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-ot0-f180.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.82.180):SA:0(-0.0/5.0):. Processed in 0.766585 secs); 14 Jun 2017 04:49:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 74.125.82.180 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=myuhWCbFZ8l2Wfkmy7CcCiF/cZLMlsMRWLZQMNjoKqA=; b=ke3/g7MYqP2TiAl7agWZHlZ3OAzpSyxCTlhmEgQXMMTBP00aQFanTqZsdcf8vWmTJf HBy1WuDlgl6t4/SitQVxI3Gl6hk78bUQUF1jDmzhuKXeFwXBzlaAYbenvsqctLSZ6Uc9 eR7m/SxzUyhWwEje8dOpgMkfIhuNk/Pnlfyfqc7c7XrpytciMIoYGN7pZSFw73Ltc+0w dRc10PfQkX0KAHWNy8/StczzRmm42SCWL9KOc1x55kmHQrxyfOCbIuBsFW5MEFdZACFL 0FFPwr3/ul6YCNwtumMuEAeX4uAXPda0YB/UmUznudiX9vJGs1zqP+UxaA3V5Ha4cKFz xWjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=myuhWCbFZ8l2Wfkmy7CcCiF/cZLMlsMRWLZQMNjoKqA=; b=Xm+5rCLLkbALtwfhkk5jjIZlqYRKeVdrCs1LVr6+ZeLELSkEde8KGFTsJbSE27y9ZK j+UBfqfCMJl1g6n13lmsP/l4k8aVe1YcVYX5dAp7PK39smzxmgKzGHp47Ei+AKT/bkjt 36XzDqI21q3bhUmeQb3OXjA+MUSj0Jam8gVqIZdQGgf+bsZZxLipg+GSuWu8rroCQYb8 zIeooeiWnbtqzUxRPkuZcGs4TshPaS/VEXJ4+YZeAaIvS0iBYOS6RWvvBI15JFSFuC5U PMtmKHv26TAaEOyGXf4rYqJmYC1LfwqjSl70coxajuW/+t7ucIfOKG5LLdpB5/FC2Ifi zqjA== X-Gm-Message-State: AKS2vOxGe1/M3p+L5tixbsFpSeB9AnoviCJy32k4Iq9+0NXhYD1eePJH 5+8p4cxS+owZftMHbG/QR29j/ehKDw== X-Received: by 10.157.24.76 with SMTP id t12mr1978815ott.145.1497415749878; Tue, 13 Jun 2017 21:49:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <170407103320.ZM27783@torch.brasslantern.com> <2017-04-08_03.58.46@mobil.systemanalysen.net> From: Mikael Magnusson Date: Wed, 14 Jun 2017 06:49:09 +0200 Message-ID: Subject: Re: Another minor =~ glitch To: Bart Schaefer Cc: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" On Wed, Jun 14, 2017 at 6:45 AM, Mikael Magnusson wrote: > On Sat, Apr 8, 2017 at 7:23 AM, Bart Schaefer wrote: >> On Fri, Apr 7, 2017 at 6:58 PM, Roland Eggner wrote: >>> >>> Regression observed since my Zsh update >>> from bb6c08b51a079870 to fc1fedda954e1d10. >> >> Thanks, that narrows it down to this: >> >> diff --git a/Src/cond.c b/Src/cond.c >> index 9b739f6..a638412 100644 >> --- a/Src/cond.c >> +++ b/Src/cond.c >> @@ -139,9 +139,9 @@ evalcond(Estate state, char *fromtest) >> l = 2; >> } >> if (name && IS_DASH(name[0])) >> - errname = name; >> + untokenize(errname = name); >> else if (strs[0] && IS_DASH(*strs[0])) >> - errname = strs[0]; >> + untokenize(errname = strs[0]); >> else >> errname = ""; >> if (name && IS_DASH(name[0]) && > > This patch causes segfaults for me (in the first hunk at least) > because name can be a readonly string. Should we ztrdup it? (I probably meant dupstring) -- Mikael Magnusson