zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: _ps1234, _date_formats: Complete strftime formats for %D{}
Date: Thu, 9 Jul 2015 15:25:38 +0200	[thread overview]
Message-ID: <CAHYJk3S8V+6TxDq9ieZErJHd5trnR+iiYRoakUYgyPve-KvniA@mail.gmail.com> (raw)
In-Reply-To: <21764.1436444277@thecus.kiddle.eu>

On Thu, Jul 9, 2015 at 2:17 PM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Mikael Magnusson wrote:
>>
>> I've also just noticed that completion after %D\{%\# and \^ doesn't
>> work, but single-quoted is fine.
>
> That's the fault of _ps1234.
>
> It's best to use compset -P and get to a point where _date_formats is
> called with $PREFIX only containing date formats and no prompt stuff.
>
> I finally worked out that the point of calling _default from _ps1234 is
> for print -P. That's _print's job to do that.

It was also so that nobody (weird?) would complain that PS1=/foo<tab>
stopped working, I think.

> +  compset -P '(\\|){' || pre=( -p "$bs{" )
> +  compset -S '(\\|)}*' || suf=( -S $bs\} )

Did you mean both $bs and \ here? You probably did, but doesn't hurt
to check :).

-- 
Mikael Magnusson


  reply	other threads:[~2015-07-09 13:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06  0:36 Mikael Magnusson
2015-07-06 11:11 ` Oliver Kiddle
2015-07-06 14:17   ` Mikael Magnusson
2015-07-06 14:56     ` Mikael Magnusson
2015-07-08 14:02   ` Jun T.
2015-07-08 14:42     ` Mikael Magnusson
2015-07-09 12:17       ` Oliver Kiddle
2015-07-09 13:25         ` Mikael Magnusson [this message]
2015-07-09 13:53         ` Mikael Magnusson
2015-07-09 15:20           ` Oliver Kiddle
2015-07-09 23:02             ` Oliver Kiddle
2015-07-09 12:22     ` Oliver Kiddle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHYJk3S8V+6TxDq9ieZErJHd5trnR+iiYRoakUYgyPve-KvniA@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=okiddle@yahoo.co.uk \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).